tests: test LowerCaseString move assignment operator #15913
Merged
snowp merged 2 commits intoenvoyproxy:mainfrom Apr 12, 2021
Merged
tests: test LowerCaseString move assignment operator #15913snowp merged 2 commits intoenvoyproxy:mainfrom
snowp merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
|
Hi @saiskee, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
Signed-off-by: Keerthan Ekbote <saiskee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Keerthan Ekbote saiskee@gmail.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Add test for LowerCaseString move assignment operator
Additional Description: improving coverage for LowerCaseString (https://storage.googleapis.com/envoy-postsubmit/main/coverage/include/envoy/http/header_map.h.gcov.html)
Risk Level: Low
Testing: Added Unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]
Beginner contribution for #1963