grid: Minor refactor of ConnectivityGrid#15909
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Apr 12, 2021
Merged
Conversation
Make members of ConnectionAttemptCallbacks private. Move logic for handling connection ready/failue from ConnectionAttemptCallbacks to WrapperCallbacks to avoid accessing private members of other classes. Signed-off-by: Ryan Hamilton <rch@google.com>
Contributor
Author
|
/assign @DavidSchinazi |
DavidSchinazi
approved these changes
Apr 10, 2021
alyssawilk
approved these changes
Apr 12, 2021
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
Make members of ConnectionAttemptCallbacks private. Move logic for handling connection ready/failue from ConnectionAttemptCallbacks to WrapperCallbacks to avoid accessing private members of other classes. Signed-off-by: Ryan Hamilton rch@google.com Risk Level: low (refactor only) Testing: N/A Docs Changes: N/A Release Notes: N/A Platform Specific Features: N/A Signed-off-by: Ryan Hamilton <rch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make members of ConnectionAttemptCallbacks private.
Move logic for handling connection ready/failue from
ConnectionAttemptCallbacks to WrapperCallbacks to avoid
accessing private members of other classes.
Signed-off-by: Ryan Hamilton rch@google.com
Risk Level: low (refactor only)
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A