Remove superfluous min from priority level pseudocode#15900
Merged
snowp merged 1 commit intoenvoyproxy:mainfrom Apr 9, 2021
Merged
Remove superfluous min from priority level pseudocode#15900snowp merged 1 commit intoenvoyproxy:mainfrom
snowp merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @dippynark, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
4eb0f1c to
1cbd7db
Compare
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
…xy#15900) Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Remove superfluous min from priority level pseudocode
Additional Description: The
priority_load(P_0)function in priority levels pseudocode documentation https://www.envoyproxy.io/docs/envoy/latest/intro/arch_overview/upstream/load_balancing/priority uses a min function which is not needed ashealth(P_0) * 100 / normalized_total_healthis always <=100Risk Level: Low
Testing: N/A
Docs Changes: Remove the superfluous min function
Release Notes: N/A
Platform Specific Features: N/A
Fixes #15824