mysql proxy: refactor BUILD struct#15885
Merged
lizan merged 5 commits intoenvoyproxy:mainfrom Apr 9, 2021
Merged
Conversation
Signed-off-by: qinggniq <livewithblank@gmail.com> fix typo Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
Contributor
Author
|
cc @lizan |
Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com> fix header order Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
lizan
approved these changes
Apr 9, 2021
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Monkeyanator
pushed a commit
to Monkeyanator/envoy
that referenced
this pull request
Apr 20, 2021
This pull request is the part of envoyproxy#15485, help reduce the work of review. - refactor the BUILD struct of mysql proxy - replace auth related fields of message from `string` to `vector`, avoid `\0` character leading message to be partial. Commit Message: refactor BUILD struct of mysql proxy Additional Description: Risk Level: Low Testing: N/A Docs Changes: N/A Release Notes: N/A Signed-off-by: qinggniq <livewithblank@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: qinggniq livewithblank@gmail.com
This pull request is the part of #15485, help reduce the work of review.
stringtovector, avoid\0character leading message to be partial.Commit Message: refactor BUILD struct of mysql proxy
Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]