Bug Fix: Record UO response flag on retry overflow circuit breaker.#1588
Merged
RomanDzhabarov merged 8 commits intomasterfrom Sep 8, 2017
Merged
Bug Fix: Record UO response flag on retry overflow circuit breaker.#1588RomanDzhabarov merged 8 commits intomasterfrom
UO response flag on retry overflow circuit breaker.#1588RomanDzhabarov merged 8 commits intomasterfrom
Conversation
mattklein123
reviewed
Sep 1, 2017
|
|
||
| if (!cluster_.resourceManager(priority_).retries().canCreate()) { | ||
| cluster_.stats().upstream_rq_retry_overflow_.inc(); | ||
| callbacks_.requestInfo().setResponseFlag(Http::AccessLog::ResponseFlag::UpstreamOverflow); |
Member
There was a problem hiding this comment.
I'm not too crazy about passing the callbacks into this object. It feels too heavyweight. IMO I would recommend returning a tri-state enum from this function (basically [Yes, No, NoOverflow] or something) and setting the response flag in the router.
Member
Author
There was a problem hiding this comment.
I was sort of planning to pass requestInfo itself into the RequestState, but returning state is fine
ebdef57 to
e64e6dc
Compare
UO response flag on retry overflow circuit breaker.UO response flag on retry overflow circuit breaker.
UO response flag on retry overflow circuit breaker.UO response flag on retry overflow circuit breaker.
mattklein123
reviewed
Sep 8, 2017
Member
mattklein123
left a comment
There was a problem hiding this comment.
looks good, thanks. small nit.
include/envoy/router/router.h
Outdated
| * @return TRUE if a retry should take place. @param callback will be called at some point in the | ||
| * future. Otherwise a retry should not take place and the callback will never be called. | ||
| * @return RetryStatus if a retry should take place. @param callback will be called at some point | ||
| * in the future. Otherwise a retry should not take place and the callback will never be called. |
Member
Author
|
@mattklein123 fixed the nit. |
mattklein123
approved these changes
Sep 8, 2017
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** This change the default encryption key used by MCP proxy to the same value as the helm's default setting. Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lyft/network-team