fix: tools vscode refreshcompd.sh fails on VSCode remote-ssh #15840
fix: tools vscode refreshcompd.sh fails on VSCode remote-ssh #15840mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @vazra, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
@lizan please have a look |
|
Can you fix DCO? In general I wouldn't recommend using the VS Code plugin downloaded clangd, instead of that use the clangd from devcontainer or use the same clangd as that to setup your SSH remote machine. |
385bc85 to
ce8a0fa
Compare
It's better to use name to kill the clangd process as it may not be always available at /opt/llvm/bin/clangd . When using VSCode remote-ssh debug the clangd will be at /home/ubuntu/.vscode-server/data/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/11.0.0/clangd_11.0.0/bin/clangd Signed-off-by: Ameen Rashad <ameen.vazhayil@datafilabs.com>
ce8a0fa to
5eb4ae2
Compare
|
@lizan, fixed the DCO. I'm not using dev-container, instead using a self provisioned cloud machine for my development workflow. |
|
@vazra I understand that you're using a self provisioned cloud machine, however the clangd downloaded by the VS code plugin is usually causing some issues, so I recommend you to install LLVM from releases.llvm.org (as the devcontainer does) to |
|
thanks @lizan , will look into that. |
Commit Message: the script (
tools/vscode/refresh_compdb.sh) is failing when vscode remote-ssh is used. It's better to use name to kill the clangd process as it may not be always available at/opt/llvm/bin/clangd. When using VSCode remote-ssh debug the clangd will be at/home/ubuntu/.vscode-server/data/User/globalStorage/llvm-vs-code-extensions.vscode-clangd/install/11.0.0/clangd_11.0.0/bin/clangdAdditional Description: changed killall to pkill [name]
Risk Level: Low
Testing: manual testing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A