api: fix go importpath for OT dep#15825
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Apr 2, 2021
Merged
Conversation
added 2 commits
April 2, 2021 13:25
Fixes a few issues with the generated Go protobuf code: a) the OT protos are not copied over, which means that their importpath needs to reference a path where it can pull the protos down from. The "logs" importpath was nonsensical and couldn't be resolved b) Bunching several proto packages into one target did not work well with the go package system. This splits the common protos out into its own target so that it can reference a different importpath than the other logs protos Signed-off-by: Snow Pettersen <snowp@lyft.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Contributor
|
/lgtm deps |
Contributor
|
Changes how the deps are used but doesn't change the dep versions |
mattklein123
approved these changes
Apr 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a few issues with the generated Go protobuf code:
a) the OT protos are not copied over, which means that their importpath
needs to reference a path where the go toolchain can pull the protos down.
The "logs" importpath was nonsensical and couldn't be resolved
b) Bunching several proto packages into one target did not work well
with the go package system. This splits the common protos out into its
own target so that it can reference a different importpath than the
other logs protos
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low, build only
Testing: Verified that go-control-plane builds with new protos
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Fixes #15817