CDS: Factor out some functionality of CDS into a helper class#15806
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Apr 1, 2021
Merged
CDS: Factor out some functionality of CDS into a helper class#15806mattklein123 merged 1 commit intoenvoyproxy:mainfrom
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
Conversation
We plan to add an OdCdsApiImpl class next to CdsApiImpl. It's config updated callback functionality would be similar to CdsApiImpl's, but with some extra code. To avoid the duplication of code, we move it to a helper class that will be used by both OdCdsApiImpl and CdsApiImpl. Signed-off-by: Krzesimir Nowak <krzesimir@kinvolk.io>
|
Hi @krnowak, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
mattklein123
approved these changes
Apr 1, 2021
Member
mattklein123
left a comment
There was a problem hiding this comment.
Awesome, thank you for splitting this out!
|
|
||
| private: | ||
| ClusterManager& cm_; | ||
| std::string name_; |
Member
There was a problem hiding this comment.
nit: const (just go ahead and do this in your next change)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
We plan to add an OdCdsApiImpl class next to CdsApiImpl. It's config
updated callback functionality would be similar to CdsApiImpl's, but
with some extra code. To avoid the duplication of code, we move it to
a helper class that will be used by both OdCdsApiImpl and CdsApiImpl.
Additional Description:
This is split out from #15523 to ease the review. It has no functional changes.
Risk Level:
Low.
Testing:
Tested as a part of #15523.
Docs Changes:
Added API docs for the newly added CdsApiHelper class.
Release Notes:
None needed.
Platform Specific Features:
None.