deps: Revert PyJWT update to 1.7.1#15781
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Mar 31, 2021
Merged
Conversation
phlax
requested changes
Mar 31, 2021
Member
phlax
left a comment
There was a problem hiding this comment.
rather than reverting all of these could you just revert the package in question please
Member
|
also this doesnt revert the breaking package |
Member
|
@Shikugawa i think it makes more sense to just open a new pr to downgrade the one breaking package - pyJWT - also if it breaks under a certain condition - perhaps trigger that if possible to ensure it is working |
Signed-off-by: Shikugawa <rei@tetrate.io>
Member
Author
|
@phlax For now pushed PyJWT downgrade. Could you take a look? |
Member
|
looks good - but to ensure this works - could you cherry-pick this commit (temporarily) onto the other PR which broke to ensure this fixes it ? |
Member
Author
Member
|
perhaps change the title
|
Closed
Contributor
|
/lgtm deps |
moderation
approved these changes
Mar 31, 2021
mattklein123
approved these changes
Mar 31, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7abb83c.
Signed-off-by: Shikugawa rei@tetrate.io
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: Downgrade PyJWT to 1.7.1. It breaks dependency checking with the required PyJWT version mismatch. For more detail https://dev.azure.com/cncf/envoy/_build/results?buildId=70789&view=logs&jobId=1c04237c-5f52-5959-5f83-5522b3556331&j=1c04237c-5f52-5959-5f83-5522b3556331&t=db3f3889-c922-566b-fa2e-4bc4948bc467
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]