Skip to content

assert: Pass in ASSERT and ENVOY_BUG location to registered callback hooks, support multiple callback hooks.#15662

Merged
antoniovicente merged 4 commits intoenvoyproxy:mainfrom
antoniovicente:named_assert_chain
Apr 1, 2021
Merged

assert: Pass in ASSERT and ENVOY_BUG location to registered callback hooks, support multiple callback hooks.#15662
antoniovicente merged 4 commits intoenvoyproxy:mainfrom
antoniovicente:named_assert_chain

Conversation

@antoniovicente
Copy link
Copy Markdown
Contributor

Commit Message:
assert: Pass in ASSERT and ENVOY_BUG location to registered callback hooks, support multiple callback hooks.

Support for multiple ASSERT and ENVOY_BUG callback hooks and location information will implementation of custom mapped stats hooks that break down hits by location.

Additional Description:
Risk Level: low
Testing: unit tests added
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a
Issue #15439

…hooks, support multiple callback hooks.

Support for multiple ASSERT and ENVOY_BUG callback hooks and location information will implementation of custom mapped stats hooks that break down hits by location.

Signed-off-by: Antonio Vicente <avd@google.com>
Signed-off-by: Antonio Vicente <avd@google.com>
Copy link
Copy Markdown
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

Signed-off-by: Antonio Vicente <avd@google.com>
@antoniovicente
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15662 (comment) was created by @antoniovicente.

see: more, trace.

@antoniovicente
Copy link
Copy Markdown
Contributor Author

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15662 (comment) was created by @antoniovicente.

see: more, trace.

Signed-off-by: Antonio Vicente <avd@google.com>
@antoniovicente antoniovicente merged commit f1c228b into envoyproxy:main Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants