-
Notifications
You must be signed in to change notification settings - Fork 5.3k
Closed
Labels
enhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.stalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recently
Description
Counters are held in the EnvoyBugRegistrationImpl keyed by filename:lineno.
In anticipation of monitoring per ENVOY_BUG hits over time, ideally ENVOY_BUGs should have a unique identifier. This change would be better made sooner rather than later while its still in early adoption. Filename:lineno isn't stable over changes.
Proposal:
Migrate ENVOY_BUG(condition, msg) to ENVOY_BUG(bug_id, condition, msg) for example (from a real usage):
ENVOY_BUG(service_stop, service_static->status_.dwCurrentState == SERVICE_RUNNING, "Attempting to stop Envoy service when it is not running");
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementFeature requests. Not bugs or questions.Feature requests. Not bugs or questions.stalestalebot believes this issue/PR has not been touched recentlystalebot believes this issue/PR has not been touched recently