Skip to content

ENVOY_BUG improvement for tracking: unique identifier #15439

@asraa

Description

@asraa

Counters are held in the EnvoyBugRegistrationImpl keyed by filename:lineno.

In anticipation of monitoring per ENVOY_BUG hits over time, ideally ENVOY_BUGs should have a unique identifier. This change would be better made sooner rather than later while its still in early adoption. Filename:lineno isn't stable over changes.

Proposal:
Migrate ENVOY_BUG(condition, msg) to ENVOY_BUG(bug_id, condition, msg) for example (from a real usage):

ENVOY_BUG(service_stop, service_static->status_.dwCurrentState == SERVICE_RUNNING, "Attempting to stop Envoy service when it is not running");

Metadata

Metadata

Labels

enhancementFeature requests. Not bugs or questions.stalestalebot believes this issue/PR has not been touched recently

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions