Skip to content

repokitteh: support random assignment from teams via /assign-from.#15594

Merged
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
htuch:assign-rk
Apr 6, 2021
Merged

repokitteh: support random assignment from teams via /assign-from.#15594
mattklein123 merged 5 commits intoenvoyproxy:mainfrom
htuch:assign-rk

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Mar 21, 2021

Signed-off-by: Harvey Tuch htuch@google.com

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/rk-bless

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

This PR has been blessed, meaning its repokitteh changes are in effect in this PR.

😽

Caused by: #15594 was labeled by repokitteh-read-only[bot].

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

🙀 Error while processing event:

evaluation error
error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:195:32: undefined: assigness:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:98: in _main
Error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:195:32: undefined: assigness
😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

🙀 Error while processing event:

evaluation error
error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:216:3: undefined: lines:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:98: in _main
Error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:216:3: undefined: lines
😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

🙀 Error while processing event:

evaluation error
error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:225:42: undefined: owner:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:98: in _main
Error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:225:42: undefined: owner
😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

🙀 Error while processing event:

evaluation error
error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:225:53: undefined: assigned:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:98: in _main
Error: github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:225:53: undefined: assigned
😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

@envoyproxy/api-shepherds assignee is @mattklein123

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds @envoyproxy/first-pass-reviewers

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

@envoyproxy/api-shepherds assignee is @htuch
@envoyproxy/first-pass-reviewers assignee is @asraa

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

/assign-from @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

@envoyproxy/api-shepherds assignee is @htuch

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch htuch unassigned asraa and htuch Mar 21, 2021
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 21, 2021

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

😽

Caused by: #15594 was synchronize by htuch.

see: more, trace.

@htuch
Ready for review.
cb30d18 
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch changed the title [WiP] repokitteh: support random assignment from teams via /assign-from. repokitteh: support random assignment from teams via /assign-from. Mar 21, 2021
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 21, 2021

This is ready for review. @itayd we really need better ways to test RK modules than mucking around in a PR :)

alyssawilk
alyssawilk previously approved these changes Mar 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!!

ci/repokitteh/modules/ownerscheck.star

def _assign_from(command, assignees):
lines = []
for team_name in command.args:
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk Mar 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this will work for multiple teams. Might want to add a documented example of
/assign-from team1 team2

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 22, 2021

🙀 Error while processing event:

evaluation error
error: list index 1 out of range [0:1]:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:224: in _assign_from
  github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:205: in _assign_from_team
Error: list index 1 out of range [0:1]
😽

Caused by: a #15594 (comment) was created by @alyssawilk.

see: more, trace.

@htuch
wip
9852579 
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 23, 2021

/assign-from team1 test/team2

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 23, 2021

🙀 Error while processing event:

evaluation error
error: function _github_call error: github error: GET https://api.github.com/orgs/envoyproxy/teams/team2: 404 Not Found []:
 Traceback (most recent call last):
  bootstrap:143: in <toplevel>
  bootstrap:135: in _main
  bootstrap:62: in _call
  bootstrap:15: in _call1
  github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:226: in _assign_from
  github.com/envoyproxy/envoy/ci/repokitteh/modules/ownerscheck.star:208: in _assign_from_team
  github:834: in team_get_by_name
  github:155: in call
Error: function _github_call error: github error: GET https://api.github.com/orgs/envoyproxy/teams/team2: 404 Not Found []
😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 23, 2021

/assign-from team team2

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Mar 23, 2021

team assignee is @None
team2 assignee is @None

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Mar 23, 2021

@itayd is it possible to do better than #15594 (comment), i.e. exploding if we have the wrong name?

@htuch
Update docs.
f82c64a 
Signed-off-by: Harvey Tuch <htuch@google.com>
@itayd
Copy link
Copy Markdown
Contributor

itayd commented Mar 24, 2021

@htuch try specifying success_codes=[200,404] in the arguments.

@alyssawilk
Copy link
Copy Markdown
Contributor

alyssawilk commented Apr 5, 2021

ping on this - it would be so lovely to wrap it up and land it!

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 6, 2021

/assign-from team team2

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 6, 2021

team assignee is @None
team2 assignee is @None

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 6, 2021

/assign-from team team2/foo

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 6, 2021

team assignee is @None
team2/foo assignee is @None

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 6, 2021

/assign-from team @envoyproxy/api-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Apr 6, 2021

team assignee is @None
@envoyproxy/api-shepherds assignee is @htuch

😽

Caused by: a #15594 (comment) was created by @htuch.

see: more, trace.

@htuch htuch removed their assignment Apr 6, 2021
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Apr 6, 2021

OK, looks like the change Itay suggested does the trick, no errors on the Slack repokitteh bot, I think we can merge this and see how it goes.

@mattklein123 mattklein123 merged commit 2e29612 into envoyproxy:main Apr 6, 2021
@htuch htuch deleted the assign-rk branch April 6, 2021 23:17
@alyssawilk alyssawilk mentioned this pull request Apr 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@alyssawilk alyssawilk alyssawilk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@itayd itayd

@alyssawilk alyssawilk

Labels

rk:blessed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@htuch @itayd @alyssawilk @asraa @mattklein123 @markdroth