xdstp: CDS/RDS/SRDS/EDS support added.#15593
Merged
htuch merged 5 commits intoenvoyproxy:mainfrom Mar 25, 2021
Merged
Conversation
This adds the foundations of support for glob collections in CDS/SRDS (in addition to LDS from envoyproxy#14311) and singleton collections in RDS/EDS. xdstp:// URLs are not normalized across the internal resource graph yet, so this is only safe to use for sorted context parameters (followup PRs planned on this). Part of envoyproxy#11264. Risk level: Low (opt-in) Testing: ADS/SRDS integration tests added, various unit tests in //test/common/config/... Signed-off-by: Harvey Tuch <htuch@google.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
adisuissa
reviewed
Mar 22, 2021
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
Overall looks good, thanks!
Signed-off-by: Harvey Tuch <htuch@google.com>
Signed-off-by: Harvey Tuch <htuch@google.com>
adisuissa
reviewed
Mar 23, 2021
Contributor
adisuissa
left a comment
There was a problem hiding this comment.
Overall looks good.
Left a couple of minor comments.
Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
@mattklein123 this is ready for review, @adisuissa has done first pass and LGTMed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the foundations of support for glob collections in CDS/SRDS
(in addition to LDS from #14311) and singletons in RDS/EDS.
xdstp:// URLs are not normalized across the internal resource graph yet,
so this is only safe to use for sorted context parameters (followup PRs
planned on this).
Part of #11264.
Risk level: Low (opt-in)
Testing: ADS/SRDS integration tests added, various unit tests in
//test/common/config/...
Signed-off-by: Harvey Tuch htuch@google.com