Skip to content

ci: don't run tests on release build#1546

Closed
mattklein123 wants to merge 1 commit intomasterfrom
mattklein123-patch-1
Closed

ci: don't run tests on release build#1546
mattklein123 wants to merge 1 commit intomasterfrom
mattklein123-patch-1

Conversation

@mattklein123
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 commented Aug 25, 2017

This is terrible but I don't see a better solution right now. We are getting
OK coverage from other tests and people can/should run tests locally
in their env anyway.

@mattklein123
ci: don't run tests on release build
9942348 
This is terrible but I don't see a better solution right now. We are getting
OK coverage from other tests and people can/should run tests locally
in their env anyway.
@mattklein123
Copy link
Copy Markdown
Member Author

mattklein123 commented Aug 25, 2017

@lyft/network-team @dnoe @alyssawilk @htuch

This pains me but I don't see a better solution right now. I feel like we can limp along like this for the next 4-8 weeks until we get off Travis?

mattklein123
mattklein123 commented Aug 25, 2017
View reviewed changes
.travis.yml
matrix:
fast_finish: true
env:
- TEST_TYPE=bazel.release
Copy link
Copy Markdown
Member Author

@mattklein123 mattklein123 Aug 25, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just realized there is one more place (or more) where this needs to be replaced. Won't bother doing unless people want to go this route.

@mattklein123
Copy link
Copy Markdown
Member Author

mattklein123 commented Aug 25, 2017

@junr03 got us 2 hour build limits somehow so closing this. Yay.

@mattklein123 mattklein123 deleted the mattklein123-patch-1 branch August 25, 2017 22:21
mathetake added a commit that referenced this pull request Mar 3, 2026
@mathetake
refactor: move the runtime filter configuration out of extproc (#1546)
397377a 
**Description**

This commit decouples "runtime filter config" that is derived from the
filterapi.Config to be able to reuse the code in dynamic modules port
#90.

**Related Issues/PRs (if applicable)**

Preparation for #90

---------

Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@mattklein123