Skip to content

wasm: allow using empty vm_id to indicate the current WasmVM.#15359

Merged
lizan merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-empty_vm_id
Mar 29, 2021
Merged

wasm: allow using empty vm_id to indicate the current WasmVM.#15359
lizan merged 3 commits intoenvoyproxy:mainfrom
PiotrSikora:wasm-empty_vm_id

Conversation

@PiotrSikora
Copy link
Copy Markdown
Contributor

Signed-off-by: Piotr Sikora piotrsikora@google.com

Signed-off-by: Piotr Sikora <piotrsikora@google.com>
@PiotrSikora PiotrSikora requested a review from lizan as a code owner March 8, 2021 07:37
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #15359 was opened by PiotrSikora.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 8, 2021
Copy link
Copy Markdown
Member

@mathetake mathetake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PiotrSikora
Copy link
Copy Markdown
Contributor Author

@moderation PTAL for deps.

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 10, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

@lizan PTAL.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Mar 24, 2021
@PiotrSikora
Copy link
Copy Markdown
Contributor Author

/lgtm deps

This was lost after the merge with the main branch. @moderation could you approve again? Thanks!

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Mar 24, 2021
@lizan lizan merged commit 87f9309 into envoyproxy:main Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants