Skip to content

protos: Cleanup unused imports#15329

Merged
htuch merged 3 commits intoenvoyproxy:mainfrom
phlax:proto-cleanups
Mar 10, 2021
Merged

protos: Cleanup unused imports#15329
htuch merged 3 commits intoenvoyproxy:mainfrom
phlax:proto-cleanups

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Mar 5, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: protos: Cleanup unused imports
Additional Description:

another attempt at removing redundant imports and reducing build noise

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
API shepherd assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #15329 was opened by phlax.

see: more, trace.

phlax added 2 commits March 5, 2021 08:54
Signed-off-by: Ryan Northey <ryan@synca.io>
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Mar 5, 2021

seems like there are not too many of these - altho udpa is still a bit of a log hog (fix? created here cncf/udpa#45)

also looked at getting rid of the awful missing dirs warning - seems like we might have a colony on mars before that iis fixed

bazelbuild/bazel#7157

whod have thunk it would be that difficult 8/

@phlax phlax changed the title [WIP] protos: Cleanup unused imports protos: Cleanup unused imports Mar 5, 2021
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Mar 5, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #15329 (comment) was created by @phlax.

see: more, trace.

Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants