http: sending the original url scheme (or best guess) upstream.#15321
http: sending the original url scheme (or best guess) upstream.#15321alyssawilk merged 6 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
mattklein123
left a comment
There was a problem hiding this comment.
Thanks LGTM modulo nit. I think it will be a miracle if this doesn't break someone but here's hoping. 🤞
/wait
source/common/router/router.cc
Outdated
| return; | ||
| } | ||
| } | ||
| bool transport_secure = |
There was a problem hiding this comment.
nit: const downstream_transport_secure
|
oh yeah, I meant to move the warning to the top because of risk. will dot that now. |
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
|
sorry, lost my LGTM with tidy and accidentally force pushed a delta but I think your review state should all be there |
…yproxy#15321) This replaces prior logic where the :scheme header was consistently overwritten based on the encryption level of the upstream connection. Risk Level: High (l7 change) Testing: new integration tests, unit tests Docs Changes: api docs updated Release Notes: inline Runtime guard: envoy.reloadable_features.preserve_downstream_scheme Part of envoyproxy#14587 Signed-off-by: Alyssa Wilk <alyssar@chromium.org> Signed-off-by: Auni Ahsan <auni@google.com>
This replaces prior logic where the :scheme header was consistently overwritten based on the encryption level of the upstream connection.
Risk Level: High (l7 change)
Testing: new integration tests, unit tests
Docs Changes: api docs updated
Release Notes: inline
Runtime guard: envoy.reloadable_features.preserve_downstream_scheme
Part of #14587