dns cache: add host info to onLoadDnsCacheComplete callback#15144
Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom Mar 3, 2021
Merged
dns cache: add host info to onLoadDnsCacheComplete callback#15144alyssawilk merged 1 commit intoenvoyproxy:mainfrom
onLoadDnsCacheComplete callback#15144alyssawilk merged 1 commit intoenvoyproxy:mainfrom
Conversation
Provide the host info in the `onLoadDnsCacheComplete` callback so that the worker threads do not have to do an additional lookup to get the resolved IP. Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
Member
|
/assign @alyssawilk |
alyssawilk
approved these changes
Mar 3, 2021
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
Argh so sorry for the delay. This looks totally solid!
chradcliffe
pushed a commit
to chradcliffe/envoy
that referenced
this pull request
Mar 15, 2021
This is a follow-up to envoyproxy#15144 that returns the requested DNS host info when the host info was already in the cache, which avoids a second lookup when the client code wants information from the cache. Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Provide the host info in the
onLoadDnsCacheCompletecallback so that the worker threads do not have to do an additional lookup to get the resolved IP.Additional Description:
Risk Level: Low - no change to functionality and code modifications are minimal
Testing: Unit testing
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A