protos/docs: Cleanups for extensions/categories#15098
Merged
htuch merged 1 commit intoenvoyproxy:mainfrom Feb 26, 2021
Merged
Conversation
Member
|
Thanks, I kind of expected there to be some followup. LMK when this is ready for review. |
1dfbfdc to
88f0efc
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
88f0efc to
9c34d36
Compare
Member
Author
phlax
commented
Feb 25, 2021
| // See the supported filters for further documentation. | ||
| // [#extension-category: envoy.filters.listener] | ||
| oneof config_type { | ||
| // Filter specific configuration which depends on the filter being |
Member
Author
There was a problem hiding this comment.
in this case it was necessary to move the comment (as well as the annotation) inside the oneof (as is done with others)
not doing so threw a formatting error - so we might need to look at the \n mangling in protodoc to make it less brittle
Member
Author
i have created a ticket for this as it will take some more time going through and thinking how best to update - #15191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: protos/docs: Cleanups for extensions/categories
Additional Description:
Some of the categories etc added in #14721 were not exactly correct and/or consistent
Also there is now some duplication from where links/info have been added manually previously
This PR should address these issues
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue] Ref #13167
[Optional Deprecated:]
[Optional API Considerations:]