build: circle-ci os x config#1507
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 22, 2017
Merged
Conversation
mattklein123
approved these changes
Aug 21, 2017
Contributor
|
+1 |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Signed-off-by: Mike Schore <mike.schore@gmail.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
added a commit
that referenced
this pull request
Mar 3, 2026
**Description** The translators shouldn't have to be tied with ext_proc APIs since it's none of their concerns. This commit decouples the translator package from them so that we can easily use them in dynamic modules too. **Related Issues/PRs (if applicable)** Preparation for #90 --------- Signed-off-by: Takeshi Yoneda <t.y.mathetake@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Circle CI configuration for a Mac OS X CI environment. Once this is on master, we can configure a webhook to trigger this build in my employer's Circle CI account and through the magic of some glue code should be a status check for Mac OS build/test. GitHub should automatically default to not blocking merges based on this check, which is the desired configuration.
The shell code in the config that deals with PULL_REQUEST et al configures a remote in the build environment's git repository in order to fetch the git SHA referenced by the pull request and merge it into our fork's master. Our fork's master is kept in sync with lyft/envoy:master.