Skip to content

Changes the link to download Kafka#14858

Merged
lizan merged 7 commits intoenvoyproxy:mainfrom
davinci26:fixKafkaDeps
Jan 29, 2021
Merged

Changes the link to download Kafka#14858
lizan merged 7 commits intoenvoyproxy:mainfrom
davinci26:fixKafkaDeps

Conversation

@davinci26
Copy link
Copy Markdown
Member

@davinci26 davinci26 commented Jan 28, 2021

Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Commit Message:

Updates link for kafka_server_binary

Additional Description: N/A
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

@davinci26
changes link to kafka
bb31873 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jan 28, 2021

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14858 was opened by davinci26.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 28, 2021
@davinci26
Copy link
Copy Markdown
Member Author

davinci26 commented Jan 28, 2021

@envoyproxy/dependency-shepherds @snowp @wrowe

@davinci26
adds stderr message
28f2c9d 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@davinci26
correct link configured
58cfce9 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@davinci26
fixes indentation
8b6d782 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@davinci26
fix query
f4345e9 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@moderation
Copy link
Copy Markdown
Contributor

moderation commented Jan 29, 2021

The old version we are on 2.4.1 has aged out of the mirrors with 2.6.1 being the oldest version on the approved mirror - https://mirrors.gigenet.com/apache/kafka/ /cc @adamkotwasinski

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 29, 2021
@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Jan 29, 2021

@davinci26 format is failing on python changes.

adamkotwasinski
adamkotwasinski reviewed Jan 29, 2021
View reviewed changes
@davinci26
fix format python
1ab4cf4 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@davinci26
change the link to point to binaries and not to source
0ddb7ad 
Signed-off-by: davinci26 <sotirisnan@gmail.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 29, 2021
@davinci26
Copy link
Copy Markdown
Member Author

davinci26 commented Jan 29, 2021

The kafka integration test is not running on my dev box but since the test is marked as manual, I am not sure if it is supposed to run on Windows. Pushing on the CI but since the executable is the same I expect it should work

wrowe
wrowe approved these changes Jan 29, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM deps

@davinci26
Copy link
Copy Markdown
Member Author

davinci26 commented Jan 29, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jan 29, 2021

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14858 (comment) was created by @davinci26.

see: more, trace.

@dio
Copy link
Copy Markdown
Member

dio commented Jan 29, 2021

Let me retest again.

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jan 29, 2021

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #14858 (comment) was created by @dio.

see: more, trace.

@dio
Copy link
Copy Markdown
Member

dio commented Jan 29, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Jan 29, 2021

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14858 (comment) was created by @dio.

see: more, trace.

@dio dio mentioned this pull request Jan 29, 2021
Closed
@yanavlasov
Copy link
Copy Markdown
Contributor

yanavlasov commented Jan 29, 2021

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines bot commented Jan 29, 2021

Azure Pipelines successfully started running 1 pipeline(s).

@davinci26
Copy link
Copy Markdown
Member Author

davinci26 commented Jan 29, 2021

The error in the verify examples is:

Successfully built 7dccf19c536a
Successfully tagged zipkin-tracing_service2:latest
Pulling zipkin (openzipkin/zipkin:)...
latest: Pulling from openzipkin/zipkin
write /var/lib/docker/tmp/GetImageBlob382198399: no space left on device
ERROR: starting zipkin .

cc @dio

@lizan lizan merged commit ffe97a3 into envoyproxy:main Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanavlasov yanavlasov yanavlasov approved these changes

+3 more reviewers

@adamkotwasinski adamkotwasinski adamkotwasinski left review comments

@wrowe wrowe wrowe approved these changes

@lizan lizan lizan approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@adamkotwasinski adamkotwasinski

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@davinci26 @moderation @yanavlasov @dio @wrowe @lizan @adamkotwasinski