docs: Gzip compressor mention non existing fields#14854
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Feb 2, 2021
Merged
docs: Gzip compressor mention non existing fields#14854lizan merged 1 commit intoenvoyproxy:mainfrom
lizan merged 1 commit intoenvoyproxy:mainfrom
Conversation
|
Hi @ctvera, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
lizan
previously approved these changes
Jan 29, 2021
Member
|
can you fix format? |
b1b7b61 to
cf2c53a
Compare
Fields `content_length`, `content_type`, `disable_on_etag_header` and `remove_accept_encoding_header` are valid for APIv2 Gzip filter, not for APIv3. Signed-off-by: Pavel Kvasnička <pavel.kvasnicka@firma.seznam.cz>
cf2c53a to
fc9f122
Compare
lizan
approved these changes
Feb 2, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fields
content_length,content_type,disable_on_etag_headerandremove_accept_encoding_headerare valid for APIv2 Gzip filter, not forAPIv3.
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: docs: Gzip compressor mention non existing fields
Additional Description:
Risk Level: Low
Testing:
Docs Changes:
Release Notes:
Platform Specific Features: