Skip to content

build: Reduce patch needed to build chromium URL#14853

Merged
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
yanavlasov:fix-chromiumurl-patch
Jan 30, 2021
Merged

build: Reduce patch needed to build chromium URL#14853
yanavlasov merged 4 commits intoenvoyproxy:mainfrom
yanavlasov:fix-chromiumurl-patch

Conversation

@yanavlasov
Copy link
Copy Markdown
Contributor

Additional Description:
Add new build target that only has sources needed for Envoy path normalization. This avoids the need to patch url_canon_host.cc

Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Yan Avlasov yavlasov@google.com

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Jan 28, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #14853 was opened by yanavlasov.

see: more, trace.

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Jan 28, 2021
@yanavlasov
Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Copy link
Copy Markdown
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks!

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov yanavlasov merged commit fc461bb into envoyproxy:main Jan 30, 2021
@yanavlasov yanavlasov deleted the fix-chromiumurl-patch branch February 1, 2021 19:24
RenjieTang added a commit to RenjieTang/envoy that referenced this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants