network: TCP proxying over HTTP POST by wlhee · Pull Request #14552 · envoyproxy/envoy

wlhee · 2021-01-03T02:29:22Z

Commit Message: Add support proxying TCP over HTTP/2 or HTTP/1.1 POST to tcp_proxy. It's controlled by tcp_proxy filter configuration. Also add support adding additional headers to the proxy requests to coordinate with the upstream. In addition, add allo_post config to router, which allow triggering the regular TCP decaping from a POST request payload.

Additional Description: N/A

Risk Level: Low

Testing: Unit tests. Integration tests.

Docs Changes: Added

Release Notes: Added

Platform Specific Features: N/A

Fixes #14234

cc @alyssawilk @mattklein123

repokitteh-read-only · 2021-01-03T02:29:29Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
API shepherd assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #14552 was opened by wlhee.

see: more, trace.

wlhee · 2021-01-03T02:40:10Z

This PR is WIP.

Would appreciate feedback about API and naming conversion first.

wlhee · 2021-01-04T21:53:20Z

/retest

repokitteh-read-only · 2021-01-04T21:53:23Z

Retrying Azure Pipelines:
Check envoy-presubmit didn't fail.

🐱

Caused by: a #14552 (comment) was created by @wlhee.

see: more, trace.

api/envoy/extensions/filters/http/tcp_post/v3/tcp_post.proto

docs/root/configuration/http/http_filters/tcp_post_filter.rst

api/envoy/extensions/filters/network/tcp_proxy/v3/tcp_proxy.proto

api/envoy/extensions/filters/http/tcp_post/v3/tcp_post.proto

source/common/tcp_proxy/upstream.cc

docs/root/configuration/http/http_filters/tcp_post_filter.rst

alyssawilk

Nice start! Tossing in some other comments while I'm looking. :-)

mattklein123

Thanks a few high level comments to get started!

/wait

api/envoy/extensions/filters/http/tcp_post/v3/tcp_post.proto

api/envoy/extensions/filters/network/tcp_proxy/v3/tcp_proxy.proto

docs/root/configuration/http/http_filters/tcp_post_filter.rst

api/envoy/config/route/v3/route_components.proto

repokitteh-read-only · 2021-01-12T05:10:38Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy[\w/]*/(v1alpha\d?|v1|v2alpha\d?|v2))|(api/envoy/type/(matcher/)?\w+.proto).

🐱

Caused by: #14552 was synchronize by wlhee.

see: more, trace.

wlhee · 2021-01-12T07:09:58Z

This PR is ready for a second round of review.

mattklein123 · 2021-01-12T18:57:39Z

From an API perspective this LGTM at a high level. Can you merge main branch and we can take another look?

/wait

wlhee · 2021-01-13T02:50:18Z

Rebased.

alyssawilk

Yeah, I think the structure of this is much cleaner without the filter. Thanks for that clean up!
Here's a few more thoughts, and we can go from there :-)

docs/root/intro/arch_overview/http/upgrades.rst

docs/root/version_history/current.rst

source/common/tcp_proxy/upstream.cc

wlhee · 2021-01-14T03:11:30Z

Updated the PR to support HTTP/1.1 POST as suggested.

alyssawilk · 2021-01-14T19:42:01Z

Cool! want to check out CI, and add the integration tests we talked about, and I'll take another look?

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

wlhee · 2021-02-02T07:34:05Z

/retest

repokitteh-read-only · 2021-02-02T07:34:09Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14552 (comment) was created by @wlhee.

see: more, trace.

wlhee · 2021-02-02T16:06:22Z

/retest

repokitteh-read-only · 2021-02-02T16:06:26Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14552 (comment) was created by @wlhee.

see: more, trace.

wlhee · 2021-02-02T16:42:34Z

CI seems very unstable recently. I just resolved the conflict of the version history, then multiple checks are failing :(

wlhee · 2021-02-02T17:43:16Z

/retest

repokitteh-read-only · 2021-02-02T17:43:20Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #14552 (comment) was created by @wlhee.

see: more, trace.

wlhee · 2021-02-02T18:40:51Z

CI is green now.

alyssawilk

@lizan can you re-stamp API and merge?

wuhuizuo · 2021-02-14T13:19:41Z

@wlhee any example codes(like C/go/rust) for setting up the connecttions to remote envoy POST terminater?

rtttech · 2021-04-19T07:38:02Z

It's really awesome, how can I use this feature in istio?

repokitteh-read-only bot added the api label Jan 3, 2021

repokitteh-read-only bot assigned lizan Jan 3, 2021

lizan reviewed Jan 4, 2021

View reviewed changes

api/envoy/extensions/filters/http/tcp_post/v3/tcp_post.proto Outdated Show resolved Hide resolved

docs/root/configuration/http/http_filters/tcp_post_filter.rst Outdated Show resolved Hide resolved

alyssawilk reviewed Jan 5, 2021

View reviewed changes

alyssawilk self-assigned this Jan 5, 2021

mattklein123 requested changes Jan 5, 2021

View reviewed changes

repokitteh-read-only bot added waiting and removed waiting labels Jan 5, 2021

mattklein123 self-assigned this Jan 6, 2021

repokitteh-read-only bot added the waiting label Jan 6, 2021

lizan reviewed Jan 7, 2021

View reviewed changes

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

api/envoy/config/route/v3/route_components.proto Outdated Show resolved Hide resolved

repokitteh-read-only bot added v2-freeze and removed waiting labels Jan 12, 2021

repokitteh-read-only bot added waiting and removed waiting labels Jan 12, 2021

wlhee force-pushed the main branch from b749a5d to 1b70966 Compare January 13, 2021 00:32

alyssawilk reviewed Jan 13, 2021

View reviewed changes

mattklein123 removed their assignment Jan 13, 2021

wlhee force-pushed the main branch from 195aae6 to 3abd4fd Compare January 14, 2021 04:09

wlhee added 6 commits February 1, 2021 14:46

Fix build rule.

7e74733

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Update comments.

a8a1a09

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Fix coverage.

1b5b9c5

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Fix router_test.

ca91819

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Fix router_test.

1379e9c

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Fix rebase issue.

a995389

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

wlhee force-pushed the main branch from f3322ce to a995389 Compare February 1, 2021 22:46

wlhee added 4 commits February 1, 2021 14:48

Update version history.

29941dd

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Update version history.

b0acb76

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Update verison history.

43aa206

Signed-off-by: Wenlei (Frank) He <wlhe@google.com>

Merge branch 'main' into main

5a803e8

alyssawilk approved these changes Feb 2, 2021

View reviewed changes

lizan approved these changes Feb 2, 2021

View reviewed changes

repokitteh-read-only bot removed the api label Feb 2, 2021

lizan merged commit effa486 into envoyproxy:main Feb 2, 2021

This was referenced Apr 19, 2021

how can I use http connect proxy in istio? #16056

Closed

http to tcp filter #15920

Closed

journaux mentioned this pull request Nov 15, 2022

Multiplexing all the way through - edge (http/2 + http/3) -> envoy -> (tcp) server #23994

Closed

Conversation

wlhee commented Jan 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jan 3, 2021

Uh oh!

wlhee commented Jan 3, 2021

Uh oh!

wlhee commented Jan 4, 2021

Uh oh!

repokitteh-read-only bot commented Jan 4, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alyssawilk left a comment

Choose a reason for hiding this comment

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

repokitteh-read-only bot commented Jan 12, 2021

Uh oh!

wlhee commented Jan 12, 2021

Uh oh!

mattklein123 commented Jan 12, 2021

Uh oh!

wlhee commented Jan 13, 2021

Uh oh!

alyssawilk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

wlhee commented Jan 14, 2021

Uh oh!

alyssawilk commented Jan 14, 2021

Uh oh!

wlhee commented Feb 2, 2021

Uh oh!

repokitteh-read-only bot commented Feb 2, 2021

Uh oh!

wlhee commented Feb 2, 2021

Uh oh!

repokitteh-read-only bot commented Feb 2, 2021

Uh oh!

wlhee commented Feb 2, 2021

Uh oh!

wlhee commented Feb 2, 2021

Uh oh!

repokitteh-read-only bot commented Feb 2, 2021

Uh oh!

wlhee commented Feb 2, 2021

Uh oh!

alyssawilk left a comment

Choose a reason for hiding this comment

Uh oh!

wuhuizuo commented Feb 14, 2021

Uh oh!

rtttech commented Apr 19, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

wlhee commented Jan 3, 2021 •

edited

Loading