Clarifying camelCase guidelines.#1420
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 9, 2017
Merged
Conversation
mattklein123
approved these changes
Aug 9, 2017
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Google style guide has accessors using snake_case and I misinterpreted the original as
"functions which use camel case have low letter first" not "functions always use camel case and have low letter first"
Minor rephrase to make that misinterpretation less likely :-)