build: update grpc to 1.34.0#14147
Conversation
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
/lgtm deps |
|
Looks like there was a failure in test, after fixing, it seems there's a fake handshake shutdown failure due to a timeout. investigating. |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
@markdroth Hi Mark, quick question. I'm trying to update gRPC and ran into a timeout failure in |
|
I ran into these same timeout issues on a prior attempt at #13394. The comment #13394 (comment) from @yashykt about the changed status codes looks like the closest thing I could find. We then decided to defer gRPC and bump protobuf independently. The gRPC commit for the status changes is at https://github.com/grpc/grpc/pull/22901/files |
Thanks @moderation! I changed the status code already, which fixed some test issues, but not the |
|
@jiangtaoli2016 @yihuazhang Sorry for asking again, I'm attempting to bump gRPC again. The HTTP response code conversions are all fixed, but the timeout remains in the ALTS integration test. I verified that the client validation actually fails, and that the issue is that This is what the trace logs used to look like https://gist.github.com/asraa/195b3b05ed217763a79f3d96f323c6fb. They're identical besides additional properties. |
|
Confirmed that grpc/grpc@837c4ce#diff-ff0681fdeb3cda181d2ac2d4b80915cd is not 100% the root cause. With a patch that reverts this commit, the tests crash, so the patch did it's part in preventing the crash. As far as the timeout, still no dice. |
|
@jiangtaoli2016 may be able to help with the ALTS problem. |
|
Just back from OOO. It looks like the problem is at the shutdown of of the FakeHandshakerService. @apolcyn last changed it with this PR. @asraa Could you revert that PR and try and see if it can shutdown correctly? |
|
@jiangtaoli2016 I do not think the PR is the culprit because it is introduced in gRPC version 1.26, and ALTS integration test still works with version 1.27. |
Signed-off-by: Asra Ali <asraa@google.com>
|
update: @jiangtaoli2016 helped debug and fixed the shutdown happening in client validation fail. change pushed however, another timeout is happening in |
|
@asraa, regarding the timeout happened in |
Signed-off-by: Asra Ali <asraa@google.com>
|
@yihuazhang Thank you so much! Tests pass :) |
|
@asraa can you take a look at format etc? |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
@asraa gRPC 1.34.0 is out if you want to try and jump all the way to latest - https://github.com/grpc/grpc/releases/tag/v1.34.0 |
|
Will do! I'm not sure why I keep hitting CI errors. Looks like one after the merge. |
Signed-off-by: Asra Ali <asraa@google.com>
Signed-off-by: Asra Ali <asraa@google.com>
|
Bumped to 1.34.0. It looks like I'm hitting this envoy/source/common/grpc/async_client_impl.cc Line 113 in f8b234b |
| version = "8a3ae1ef3e3e3f26b45dec735c5776737fc7247f", | ||
| sha256 = "e9f281c56ab1eb1f97a80ca8a83bb7ef73d230eabb8591f83876f4e7b85d9b47", | ||
| version = "382d5afc60e05470c23e8de19b19fc5ad231e732", | ||
| sha256 = "7992217989f3156f8109931c1fc6db3434b7414957cb82371552377beaeb9d6c", | ||
| strip_prefix = "upb-{version}", | ||
| urls = ["https://github.com/protocolbuffers/upb/archive/{version}.tar.gz"], | ||
| use_category = ["controlplane"], | ||
| release_date = "2019-11-19", | ||
| release_date = "2020-08-03", |
There was a problem hiding this comment.
Latest upb if you want to use that is:
upb = dict(
project_name = "upb",
project_desc = "A small protobuf implementation in C (gRPC dependency)",
project_url = "https://github.com/protocolbuffers/upb",
version = "794ce6d06188c6df290b4b46b4c32e95a219eafc",
sha256 = "1920bdcb3b963db424ce0a0e6cdcc9d5b5d48ef3c95bb79823ba3c8f63422d01",
release_date = "2020-11-26",
strip_prefix = "upb-{version}",
urls = ["https://github.com/protocolbuffers/upb/archive/{version}.tar.gz"],
use_category = ["controlplane"],
cpe = "N/A",
),
|
CI is passing besides the existing clang_tidy issue |
|
/cc @mattklein123 as envoy/source/common/grpc/async_client_impl.cc Line 113 in f8b234b |
|
/lgtm deps |
Signed-off-by: Asra Ali <asraa@google.com>
|
Upstream merged, clang-tidy is still pre-existing. |
Signed-off-by: Asra Ali <asraa@google.com>
|
@mattklein123 @moderation Sorry for bumping this again, but merged in main, clang-tidy is still failing on existing TODO |
|
OK let's force merge given it's an existing issue. |
Signed-off-by: Asra Ali asraa@google.com
Commit Message: Updates gRPC dependency to version 1.33.2. Also updates upb as a requirement, and removes a stale patch.
Additional Description:
Risk Level: Low, but not non-existent? There was a gRPC default change.
Testing: Added regression test for fuzz bug.
Fixes:
https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=27307