examples: add VRP runtime validation to verify_examples.#14099
Merged
htuch merged 3 commits intoenvoyproxy:masterfrom Nov 20, 2020
Merged
examples: add VRP runtime validation to verify_examples.#14099htuch merged 3 commits intoenvoyproxy:masterfrom
htuch merged 3 commits intoenvoyproxy:masterfrom
Conversation
This is a regression test to cover the issue underlying envoyproxy#14066. Risk level: Low Testing: Validating manually verify.sh passes, CI. Signed-off-by: Harvey Tuch <htuch@google.com>
Member
Author
|
CC @akonradi |
phlax
requested changes
Nov 19, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
LGTM modulo @phlax comment and potential suggestion.
/wait
| @@ -0,0 +1 @@ | |||
| FROM envoyproxy/envoy-google-vrp-dev:latest | |||
Member
There was a problem hiding this comment.
WDYT about just moving VRP into examples? It is technically an example of a somewhat secure configuration? Would that be simpler and more self contained?
Member
Author
There was a problem hiding this comment.
Not sure how this would integrate with the DockerHub push flow. Examples run after the base images that get pushed to DockerHub are built in CI. Do we push any other examples to DockerHub?
Member
There was a problem hiding this comment.
Yeah dunno, just a thought. NBD.
Signed-off-by: Harvey Tuch <htuch@google.com>
mattklein123
approved these changes
Nov 19, 2020
andreyprezotto
pushed a commit
to andreyprezotto/envoy
that referenced
this pull request
Nov 24, 2020
…14099) This is a regression test to cover the issue underlying envoyproxy#14066. Risk level: Low Testing: Validating manually verify.sh passes, CI. Signed-off-by: Harvey Tuch <htuch@google.com>
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
…14099) This is a regression test to cover the issue underlying envoyproxy#14066. Risk level: Low Testing: Validating manually verify.sh passes, CI. Signed-off-by: Harvey Tuch <htuch@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a regression test to cover the issue underlying
#14066.
Risk level: Low
Testing: Validated manually verify.sh passes, CI.
Signed-off-by: Harvey Tuch htuch@google.com