matching: only provide string matcher in SinglePredicate#14084
matching: only provide string matcher in SinglePredicate#14084snowp merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
|
https://envoyproxy.slack.com/archives/CEFDKQ3RQ/p1605272565120300 is the thread in question fyi @markdroth and more generally @envoyproxy/api-shepherds |
htuch
left a comment
There was a problem hiding this comment.
LGTM. I think we're going to have to include extensions from the get go to bring back functionality that exists in route matching in the range_match field.
|
@htuch Yep I agree. Somewhat begs the question of whether everything should be an extension and there be no standard matcher, but I think this should make the simpler matching cases easier to do for users so I think it's worth it. |
|
I think it's fine to use extensions for things like the routing matching |
…14084) Signed-off-by: Snow Pettersen <snowp@lyft.com>
…14084) Signed-off-by: Snow Pettersen <snowp@lyft.com> Signed-off-by: Qin Qin <qqin@google.com>
Signed-off-by: Snow Pettersen snowp@lyft.com
Per Slack convo this changes the SinglePredicate default matcher to only match against strings. This simplifies the handling of this default matcher as we can assume that all the inputs are strings and we assume no other types being encoded in the output string. This can be left to extensions that might want to interpret something like JSON values as structured strings.
Risk Level: Low, API not used
Testing: n/a
Docs Changes: n/a
Release Notes: n/a