dispatcher: Remove obsolete runtime feature envoy.reloadable_features.activate_fds_next_event_loop#14055
Merged
ggreenway merged 2 commits intoenvoyproxy:masterfrom Nov 18, 2020
Conversation
….activate_fds_next_event_loop Signed-off-by: Antonio Vicente <avd@google.com>
ggreenway
requested changes
Nov 17, 2020
Member
ggreenway
left a comment
There was a problem hiding this comment.
release note? In case someone has it in their config, so they know to remove it to de-clutter
Signed-off-by: Antonio Vicente <avd@google.com>
ggreenway
approved these changes
Nov 18, 2020
Member
|
/retest |
|
Retrying Azure Pipelines: |
andreyprezotto
pushed a commit
to andreyprezotto/envoy
that referenced
this pull request
Nov 24, 2020
….activate_fds_next_event_loop (envoyproxy#14055) Feature flag was introduced in PR envoyproxy#11750 on 2020-06-27. Would be good to obsolete in preparation to changes to activate/setEnable behavior which should make activate behavior more intuitive and simplify edge trigger emulation and userspace file event implementations. Signed-off-by: Antonio Vicente <avd@google.com>
qqustc
pushed a commit
to qqustc/envoy
that referenced
this pull request
Nov 24, 2020
….activate_fds_next_event_loop (envoyproxy#14055) Feature flag was introduced in PR envoyproxy#11750 on 2020-06-27. Would be good to obsolete in preparation to changes to activate/setEnable behavior which should make activate behavior more intuitive and simplify edge trigger emulation and userspace file event implementations. Signed-off-by: Antonio Vicente <avd@google.com> Signed-off-by: Qin Qin <qqin@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
dispatcher: Remove obsolete runtime feature envoy.reloadable_features.activate_fds_next_event_loop
Additional Description:
Feature flag was introduced in PR #11750 on 2020-06-27. Would be good to obsolete in preparation to changes to activate/setEnable behavior which should make activate behavior more intuitive and simplify edge trigger emulation and userspace file event implementations.
Risk Level: low
Testing: n/a
Docs Changes: n/a
Release Notes: n/a