Skip to content

build: update protobuf to 3.13.0#13712

Merged
lizan merged 4 commits intoenvoyproxy:masterfrom
lizan:protobuf_update
Oct 27, 2020
Merged

build: update protobuf to 3.13.0#13712
lizan merged 4 commits intoenvoyproxy:masterfrom
lizan:protobuf_update

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Oct 22, 2020

Signed-off-by: Lizan Zhou lizan@tetrate.io

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 22, 2020
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #13712 was opened by lizan.

see: more, trace.

@kyessenov
Copy link
Copy Markdown
Contributor

cc @moderation

@moderation
Copy link
Copy Markdown
Contributor

LGTM and thanks for picking this up.

I made the mistake on my non-gRPC retry of adding more stuff which broke more stuff etc. So good to land this and we can bump some dependencies around it

moderation
moderation previously approved these changes Oct 22, 2020
@lizan
Copy link
Copy Markdown
Member Author

lizan commented Oct 22, 2020

Seems lua wrapper fails about 50% chance, will look into it:

//test/extensions/filters/http/lua:wrappers_test                         FAILED in 51 out of 100 in 11.4s

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
lizan added 2 commits October 24, 2020 00:26
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@lizan lizan requested a review from htuch October 26, 2020 22:58
@lizan lizan merged commit 9e983b0 into envoyproxy:master Oct 27, 2020
@lizan lizan deleted the protobuf_update branch October 27, 2020 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants