api: update doc to clarify match_subject_alt_names is optional and fix a typo#13696
Merged
htuch merged 1 commit intoenvoyproxy:masterfrom Oct 22, 2020
Merged
api: update doc to clarify match_subject_alt_names is optional and fix a typo#13696htuch merged 1 commit intoenvoyproxy:masterfrom
htuch merged 1 commit intoenvoyproxy:masterfrom
Conversation
…x a typo Signed-off-by: Sanjay Pujare <sanjaypujare@google.com>
Contributor
Author
Contributor
|
@sanjaypujare Thank you so much for doing this. |
chradcliffe
pushed a commit
to chradcliffe/envoy
that referenced
this pull request
Oct 23, 2020
…x a typo (envoyproxy#13696) The comment in v3 version was missing the "If specified.." clause from the v2 version of that comment Risk Level: low Testing: Ran ./ci/run_envoy_docker.sh './ci/do_ci.sh fix_format' Docs Changes: comment in a proto file changed Signed-off-by: Sanjay Pujare <sanjaypujare@google.com> Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sanjay Pujare sanjaypujare@google.com
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Commit Message: api: update doc to clarify match_subject_alt_names is optional and fix a typo
Additional Description: The comment in v3 version was missing the "If specified.." clause from the v2 version of that comment
Risk Level: low
Testing: Ran
./ci/run_envoy_docker.sh './ci/do_ci.sh fix_format'Docs Changes: comment in a proto file changed
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]