Skip to content

xds: Clarify limitations of resource type instance version.#13687

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
markdroth:xds_system_version_clarification
Oct 22, 2020
Merged

xds: Clarify limitations of resource type instance version.#13687
htuch merged 1 commit intoenvoyproxy:masterfrom
markdroth:xds_system_version_clarification

Conversation

@markdroth
Copy link
Copy Markdown
Contributor

Signed-off-by: Mark D. Roth roth@google.com

Commit Message: xds: Clarify limitations of resource type instance version.
Additional Description: Clarify that the server may not resend resources upon stream restart only if it has some way to know that the client is not subscribing to new resources that it wasn't previously subscribed to.
Risk Level: Low
Testing: N/A
Docs Changes: Included in PR
Release Notes: N/A
Platform Specific Features: N/A

Clarifies text added in #12580. CC @htuch

Signed-off-by: Mark D. Roth <roth@google.com>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit adc569c into envoyproxy:master Oct 22, 2020
@markdroth markdroth deleted the xds_system_version_clarification branch October 22, 2020 21:30
chradcliffe pushed a commit to chradcliffe/envoy that referenced this pull request Oct 23, 2020
)

Clarify that the server may not resend resources upon stream restart only if it has some way to know that the client is not subscribing to new resources that it wasn't previously subscribed to.

Risk Level: Low
Testing: N/A
Docs Changes: Included in PR

Clarifies text added in envoyproxy#12580.

Signed-off-by: Mark D. Roth <roth@google.com>
Signed-off-by: Craig Radcliffe <craig.radcliffe@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants