Skip to content

dependencies: compute and check release dates via GitHub API.#13582

Merged
htuch merged 5 commits intoenvoyproxy:masterfrom
htuch:release-date
Oct 20, 2020
Merged

dependencies: compute and check release dates via GitHub API.#13582
htuch merged 5 commits intoenvoyproxy:masterfrom
htuch:release-date

Conversation

@htuch
Copy link
Copy Markdown
Member

@htuch htuch commented Oct 15, 2020 •
edited
Loading

The use of last_updated was ambiguous (is it when an Envoy contributor
creates a PR, merges a commit, or when the dependency is released?).
We really are after the release date as a measure of how stale the
dependency is.

This patch introduces a tool, tools/dependency/release_dates.py, that
uses the GitHub API to compute release date. If a mismatch is detected, an
error is raised.

This patch also introduces a dependency validation CI job that gathers existing
scripts and the release_dates.py script into a single job.

Co-authored-by: Michael Payne michael@sooper.org
Signed-off-by: Harvey Tuch htuch@google.com

@htuch @moderation
[WiP] dependencies: compute release dates via GH API.
73abe76 
The use of last_updated was ambiguous (is it when an Envoy contributor
creates a PR, merges a commit, or when the dependency is released?).
We really are after the release date as a measure of how stale the
dependency is.

This patch introduces a tool, tools/dependency/release_dates.py, that
uses the GitHub API to compute release date.

Co-authored-by: Michael Payne <michael@sooper.org>
Signed-off-by: Harvey Tuch <htuch@google.com>
@htuch htuch requested a review from moderation October 15, 2020 00:33
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 15, 2020
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Oct 15, 2020

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13582 was opened by htuch.

see: more, trace.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 15, 2020

CC @PiotrSikora @envoyproxy/dependency-shepherds

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 15, 2020 •
edited
Loading

@PiotrSikora @danzh2010 @dio can you update on whether the last_updated dates on the release bundles that live on GCS and belong to the com_googlesource_* dependencies that you introduced or maintain reflect "last updated in Envoy" or "release date"? thanks.

@PiotrSikora
Copy link
Copy Markdown
Contributor

PiotrSikora commented Oct 15, 2020

@htuch V8's release date should be 2020-08-17 (for 8.5.210.20), BoringSSL's release date is correct.

dio
dio reviewed Oct 15, 2020
View reviewed changes
danzh2010
danzh2010 reviewed Oct 15, 2020
View reviewed changes
@htuch htuch changed the title [WiP] dependencies: compute release dates via GH API. dependencies: compute and check release dates via GitHub API. Oct 19, 2020
@htuch htuch marked this pull request as ready for review October 19, 2020 14:51
moderation
moderation previously approved these changes Oct 19, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 19, 2020
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 19, 2020

@lizan this is ready for review; it's stuck on not having GH_ACCESS_TOKEN set, since we need to populate Azure with an access token for "public repo read-only" access to the API.

@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 19, 2020

This PR now passes the new CI "precheck dependencies" :)

lizan
lizan reviewed Oct 20, 2020
View reviewed changes
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 20, 2020
@htuch
Copy link
Copy Markdown
Member Author

htuch commented Oct 20, 2020

MacOS failures looks RBE related, https://dev.azure.com/cncf/envoy/_build/results?buildId=54800&view=logs&j=b4895c6e-031d-5a9e-a507-86b9350b5c70&t=b4ab6edc-d679-5a1d-980f-d72dcbda6eb1. Will force merge.

@htuch htuch merged commit 91f2bb7 into envoyproxy:master Oct 20, 2020
@htuch htuch deleted the release-date branch October 20, 2020 19:23
@htuch htuch mentioned this pull request Oct 20, 2020
Merged
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 21, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
cd06c28 
* master: (22 commits)
  ci: various improvements (envoyproxy#13660)
  dns: fix defunct fd bug in apple resolver (envoyproxy#13641)
  build: support ppc64le with wasm (envoyproxy#13657)
  [fuzz] Added random load balancer fuzz (envoyproxy#13400)
  dependencies: compute and check release dates via GitHub API. (envoyproxy#13582)
  mac ci: try ignoring update failure (envoyproxy#13658)
  watchdog: Optimize WatchdogImpl::touch in preparation to more frequent petting of the watchdog. (envoyproxy#13103)
  typos: fix a couple 'enovy' mispellings (envoyproxy#13645)
  lua: Expose stream info downstreamLocalAddress and downstreamDirectRemoteAddress for Lua filter (envoyproxy#13536)
  tap: fix upstream streamed transport socket taps (envoyproxy#13638)
  Revert "delay health checks until transport socket secrets are ready. (envoyproxy#13516)" (envoyproxy#13639)
  Watchdog: use abort action as a default if killing is enabled. (envoyproxy#13523)
  [fuzz] Fixed divide by zero bug (envoyproxy#13545)
  wasm: flip the meaning of the "repository" in envoy_wasm_cc_binary(). (envoyproxy#13621)
  fix: record recovered local address (envoyproxy#13581)
  docs: fix incorrect compressor filter doc (envoyproxy#13611)
  docs: clean up docs for azp migration (envoyproxy#13558)
  wasm: fix building Wasm example. (envoyproxy#13619)
  test: Refactor flood tests into a separate test file (envoyproxy#13556)
  wasm: re-enable tests with precompiled modules. (envoyproxy#13583)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danzh2010 danzh2010 danzh2010 left review comments

+3 more reviewers

@dio dio dio left review comments

@lizan lizan lizan approved these changes

@moderation moderation moderation left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@lizan lizan

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@htuch @PiotrSikora @dio @moderation @lizan @danzh2010