Add Platform Specific Feature guidance to PR template#13547
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 14, 2020
greenhouse-org:pr-template-platform-specific-features
Merged
Add Platform Specific Feature guidance to PR template#13547mattklein123 merged 1 commit intoenvoyproxy:masterfrom greenhouse-org:pr-template-platform-specific-features
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:pr-template-platform-specific-features
Conversation
Signed-off-by: Sunjay Bhatia <sunjayb@vmware.com>
htuch
reviewed
Oct 13, 2020
Member
htuch
left a comment
There was a problem hiding this comment.
LGTM, @envoyproxy/maintainers for visibiltiy
junr03
reviewed
Oct 13, 2020
Member
junr03
left a comment
There was a problem hiding this comment.
Thanks! I was looking forward to this after you discussed it in this morning's community meeting. This will also be relevant for Apple and Android specific changes (as we have had in the past driven by needs in Envoy Mobile).
mpuncel
added a commit
to mpuncel/envoy
that referenced
this pull request
Oct 15, 2020
* master: ci: use multiple stage (envoyproxy#13557) tls: update BoringSSL to 2192bbc8 (4240). (envoyproxy#13567) fix macos v8 build (envoyproxy#13572) Fixed Health Check Fuzz corpus syntax (envoyproxy#13576) ci: Remove shellcheck diff (envoyproxy#13560) ci: Increate brew retry interval (envoyproxy#13565) dependencies: fix some of the fallout from Wasm merge. (envoyproxy#13569) hds: add support for delta updates in specifier (envoyproxy#13067) ci: workaround for actions/runner-images#1811 (envoyproxy#13577) ratelimit: be able to disable x-envoy-ratelimited response header sent (envoyproxy#13270) Update opencensus library (envoyproxy#13549) ci: use azp for api and go-control-plane sync (envoyproxy#13550) docs: Remove/make generic lyft references in docs (envoyproxy#13559) check_format: adding 2 more release note checks (envoyproxy#13444) [Wasm] Add cluster metadata fallback and upstream host metadata (envoyproxy#13477) [fuzz] Added validation for secrets (envoyproxy#13543) Add Platform Specific Feature guidance to PR template (envoyproxy#13547) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Add Platform Specific Feature guidance to PR template
Additional Description: The intent of this change is to ensure platform specific features or features that a contributor PRs without for example Windows support fully implemented get a tracking issue and specific consideration from that fact from reviewers. This will help some of the platform-specific contributor groups to discover the gaps that need to be filled on a given platform without having to follow each PR.
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A