Skip to content

Windows: Deprecate moonjit support#13541

Merged
htuch merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:lua-jit-patch
Oct 16, 2020
Merged

Windows: Deprecate moonjit support#13541
htuch merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:lua-jit-patch

Conversation

@wrowe
Copy link
Copy Markdown
Contributor

@wrowe wrowe commented Oct 13, 2020 •
edited
Loading

Commit Message: Windows: Deprecate moonjit support
Additional Description:

See #13539

This is not the entire resolution of the issue, only a simplification

Risk Level: low
Testing: minimal
Docs Changes: n/a here (see c711935)
Release Notes: n/a here (see c711935)

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 13, 2020
@repokitteh-read-only
Copy link
Copy Markdown

repokitteh-read-only bot commented Oct 13, 2020

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt).

🐱

Caused by: #13541 was opened by wrowe.

see: more, trace.

@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Oct 13, 2020

@htuch we can glue this all back together however you like, I wasn't going to deal with merge breakage to master this morning. Just watching the Windows CI result specifically. Whether you want to deprecate moonjit in this PR is your call, or I will cherry pick that into a new PR.

@htuch
Copy link
Copy Markdown
Member

htuch commented Oct 13, 2020

@wrowe thanks, I've patched this into #13474. Fine to take the MoonJit removal for Windows.

moderation
moderation reviewed Oct 13, 2020
View reviewed changes
@htuch htuch self-assigned this Oct 13, 2020
@wrowe wrowe marked this pull request as draft October 13, 2020 22:37
@wrowe
Deprecate moonjit support on Windows before beta
dc5c3bb 
See #13539

Signed-off-by: William A Rowe Jr <wrowe@vmware.com>
@wrowe wrowe changed the title Windows: LuaJIT patch to the commit c711935 changes Windows: Deprecate moonjit support Oct 15, 2020
@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Oct 15, 2020

Holding on merge of #13474

/wait

@wrowe
Copy link
Copy Markdown
Contributor Author

wrowe commented Oct 15, 2020

cc @envoyproxy/windows-dev just FYI

No reason to hold off. The windows port makes no reference to toggling moonjit. This patch simply drops all workarounds per the cited issue 13539 to make the residual patch much simpler, between now and decommissioning moonjit support altogether.

Converting this to a ready state, since it has no overlap with the current bump to luajit #13474

@wrowe wrowe marked this pull request as ready for review October 15, 2020 20:32
htuch
htuch approved these changes Oct 16, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 3b4d652 into envoyproxy:master Oct 16, 2020
mpuncel added a commit to mpuncel/envoy that referenced this pull request Oct 17, 2020
@mpuncel
Merge branch 'master' into mpuncel/http2-hc-goaway
b76c46e 
* master: (22 commits)
  delay health checks until transport socket secrets are ready. (envoyproxy#13516)
  test, oauth2: Make sure config test runs field validation (envoyproxy#13496)
  [http] swap codec implementations to default new (envoyproxy#13579)
  wasm: update proxy-wasm-cpp-host (envoyproxy#13606)
  postgres: do not copy and linearize received data when it is not going to be used (envoyproxy#13393)
  configs: Update configs v2 -> v3 (envoyproxy#13562)
  http2: Remove RELEASE_ASSERTs in sendPendingFrames() error handling (envoyproxy#13546)
  dependencies: track untracked implied dependencies, wrapup dashboard. (envoyproxy#13571)
  listener: add match all filter chain (envoyproxy#13449)
  fix mistakes in docstrings (envoyproxy#13603)
  ratelimit: add route entry metadata to ratelimit actions (envoyproxy#13269)
  cluster manager: avoid immediate activation for dynamic inserted cluster when initialize (envoyproxy#12783)
  ext_authz: Avoid calling check multiple times (envoyproxy#13288)
  docs: Unexclude remaining configs from validation (envoyproxy#13534)
  build: update rules_rust to allow Rustc in RBE (envoyproxy#13595)
  docs: Update sphinxext.rediraffe (envoyproxy#13589)
  Deprecate moonjit support on Windows before beta (envoyproxy#13541)
  dependencies: bump LuaJIT to 2.1 branch HEAD @ e9af1ab. (envoyproxy#13474)
  docs: add TLS stats to cluster stats doc (envoyproxy#13561)
  ci: stop building alpine-debug images in favor of ubuntu-based debug image (envoyproxy#13598)
  ...

Signed-off-by: Michael Puncel <mpuncel@squareup.com>
@wrowe wrowe deleted the lua-jit-patch branch October 23, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@moderation moderation moderation left review comments

@htuch htuch htuch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@htuch htuch

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wrowe @htuch @moderation