test: disable exact memory checks until we can sort out what changed in tcmalloc#13447
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Oct 8, 2020
Merged
Conversation
…allo Signed-off-by: Joshua Marantz <jmarantz@google.com>
cpakulski
pushed a commit
to cpakulski/envoy
that referenced
this pull request
Nov 18, 2020
…alloc (envoyproxy#13447) Signed-off-by: Joshua Marantz <jmarantz@google.com> Signed-off-by: Christoph Pakulski <christoph@tetrate.io>
Contributor
|
Backported to release 1.16. Other releases are not affected. Removing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: tcmalloc changed and the data coming out of
tcmalloc::MallocExtension::GetNumericProperty("generic.current_allocated_bytes")no longer appears to be deterministic, even in unthreaded tests. So disable exact mem checks till we sort that outAdditional Description:
Risk Level: low
Testing: just thread_local_store_test
Docs Changes: n/a
Release Notes: n/a