stats: remove references to fake symbol tables.#13392
Merged
mattklein123 merged 10 commits intoenvoyproxy:masterfrom Oct 6, 2020
Merged
stats: remove references to fake symbol tables.#13392mattklein123 merged 10 commits intoenvoyproxy:masterfrom
mattklein123 merged 10 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
mattklein123
reviewed
Oct 5, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Nice! LMK when this is read for review.
/wait
…re comparing output. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
…or fake symtab option warning. Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Member
|
Check tidy and then I can take a look? /wait |
Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Now that real symbol tables have been baking for 3 months its time to remove the fake ones. The option will still be available to avoid breaking production scripts in the same PR, but that will go sometime soon as well (#13399)
Additional Description:
Risk Level: medium -- if someone has a deployment where they were depending on using fake symbol tables due to some performance or functional issue that was otherwise unnoticed, this change will move them to real symbol tables, emitting a warning once on startup.
Testing: //test/...
Docs Changes: updated stats.md
Release Notes: done
Fixes #6307