tracing: Fix spankind = CLIENT bug when sharedSpanContext is false#13193
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Sep 21, 2020
Merged
tracing: Fix spankind = CLIENT bug when sharedSpanContext is false#13193mattklein123 merged 1 commit intoenvoyproxy:masterfrom
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Gary Brown <gary@brownuk.com>
6724052 to
fa0c06d
Compare
Member
|
/retest |
|
Retrying Azure Pipelines, to retry CircleCI checks, use |
dio
approved these changes
Sep 21, 2020
Member
dio
left a comment
There was a problem hiding this comment.
Thanks, @objectiser! Most of my comments will be on how we put comments (as a complete sentence), but I have a plan to drop v1 and model this tracer to support v2 only, probably we can do that when the time comes 🙂.
dio
reviewed
Sep 21, 2020
| SpanPtr parent_span = tracer.startSpan(config, "parent_span", timestamp); | ||
| SpanContext parent_context(*parent_span); | ||
|
|
||
| // An CS annotation must have been added |
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Sep 29, 2020
false (envoyproxy#13193) Signed-off-by: Gary Brown <gary@brownuk.com> Signed-off-by: Dmitri Dolguikh <dolguik@redhat.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Oct 2, 2020
false (envoyproxy#13193) Signed-off-by: Gary Brown <gary@brownuk.com> Signed-off-by: Dmitri Dolguikh <ddolguik@redhat.com>
istio-testing
pushed a commit
to istio/envoy
that referenced
this pull request
Oct 5, 2020
false (envoyproxy#13193) Signed-off-by: Gary Brown <gary@brownuk.com> Signed-off-by: Dmitri Dolguikh <dolguik@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Introducing the
sharedSpanContextflag, to control whether shared or new span ids were used, inadvertently affected the value used for the span kind annotation. This PR separates out setting the annotation from the logic controlling whether span ids are shared or not.Risk Level: low
Testing: Enhanced the unit tests.
Docs Changes: n/a
Release Notes:
Fixes #13141