api: add node field to csds request#12522
Conversation
Signed-off-by: Yutong Li <yutongli@google.com>
Signed-off-by: Yutong Li <yutongli@google.com>
|
I don't understand why this is needed. There's already a way to match on the node ID field in the |
|
As per offline discussion, it seems like what you want here is not a way to select the data that you want CSDS to return but rather a way to identify the CSDS client to the CSDS server. In that case, I suspect the right way to do it is to add a That having been said, I'm not actually all that familiar with how CSDS is used, so I'm going to defer to @htuch or one of the other API shephards to review this. |
|
Yes, I think this probably belongs in the Node ID or metadata. |
|
@markdroth @htuch Just want to make sure that what you suggested is replacing the string |
|
Yes, exactly. |
|
Yeah, it seems reasonable to re-use this structure if we consider nodes to be Envoy/gRPC clients, intermediaries such as proxies, CSDS, etc. |
Signed-off-by: Yutong Li <yutongli@google.com>
|
@markdroth @htuch Thanks for the suggestion! I've modified the csds request by adding a /cc @fuqianggao |
|
LGTM |
Commit Message: added an
nodefield to csds request to identify the CSDS client to the CSDS server, and removed the[#not-implemented-hide:]for theendpoint_configsince it has been implemented in #11577Additional Description:
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Yutong Li yutongli@google.com
/cc @fuqianggao @alexburnos