build: change to language minimal#1249
Merged
mattklein123 merged 1 commit intomasterfrom Jul 12, 2017
Merged
Conversation
mattklein123
approved these changes
Jul 12, 2017
Contributor
|
This seems to be generating a warning in Travis output: "[x] in language section: illegal value minimal, defaulting to ruby" But the rest of the output looks fine? |
Contributor
|
Familiar face of @PiotrSikora on this issue... Maybe we want to change to |
Member
Author
|
@dnoe I am aware of all of that. I'm working with Travis to understand this all. They don't have clear documentation in place. I'll update this with resolution as I get it. |
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: this PR fixes leaks in the platform filter stack: - iOS was leaking a weak ptr allocated on the heap when the filter was synchronous. Android was not because Android unconditionally wraps the heap allocated pointer with a GC managed object. - headers and trailer structs were leaking under some conditions on filter.cc - error messages were leaking if the platform filter did not have a on error callback set. Risk Level: med - previous versions of Envoy Mobile that use platform filters were leaking. Testing: ran the Lyft app under the leak checker. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: this PR fixes leaks in the platform filter stack: - iOS was leaking a weak ptr allocated on the heap when the filter was synchronous. Android was not because Android unconditionally wraps the heap allocated pointer with a GC managed object. - headers and trailer structs were leaking under some conditions on filter.cc - error messages were leaking if the platform filter did not have a on error callback set. Risk Level: med - previous versions of Envoy Mobile that use platform filters were leaking. Testing: ran the Lyft app under the leak checker. Signed-off-by: Jose Nino <jnino@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This adds end-to-end support for pass through openai /completions. A follow-up will add observability and close out the feature. **Related Issues/PRs** Continues #1231 Signed-off-by: Adrian Cole <adrian@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@lyft/network-team Travis suggested changing to language: minimal to save more space.