Skip to content

tidy: allow run clang_tidy with file#12458

Closed
lizan wants to merge 32 commits intoenvoyproxy:masterfrom
lizan:tidy_file
Closed

tidy: allow run clang_tidy with file#12458
lizan wants to merge 32 commits intoenvoyproxy:masterfrom
lizan:tidy_file

Conversation

@lizan
Copy link
Copy Markdown
Member

@lizan lizan commented Aug 4, 2020

Refactor ci/clang_tidy.sh and ci/do_ci.sh to allow run clang-tidy for specified source file. Make running clang_tidy with build container or within devcontainer easier.

Risk Level: Low
Testing: Local, CI
Docs Changes: Yes
Release Notes: N/A

Signed-off-by: Lizan Zhou lizan@tetrate.io

Petr Pchelko and others added 24 commits July 31, 2020 10:46
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
dio
dio previously approved these changes Aug 4, 2020
Copy link
Copy Markdown
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

if [[ -z "${DIFF_REF}" ]]; then
if [[ "${BUILD_REASON}" == "PullRequest" ]]; then
DIFF_REF="remotes/origin/${SYSTEM_PULLREQUEST_TARGETBRANCH}"
else [[ "${BUILD_REASON}" == *CI ]]; then
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif

Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@dio
Copy link
Copy Markdown
Member

dio commented Aug 4, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

dio
dio previously approved these changes Aug 4, 2020
Copy link
Copy Markdown
Member

@dio dio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dio
Copy link
Copy Markdown
Member

dio commented Aug 4, 2020

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Petr Pchelko and others added 7 commits August 4, 2020 10:29
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Petr Pchelko <ppchelko@wikimedia.org>
Signed-off-by: Lizan Zhou <lizan@tetrate.io>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12458 was synchronize by lizan.

see: more, trace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants