Merged
Conversation
Member
Author
|
@htuch I'm not very good at Python but what you had here before didn't work for me. I tried to understand the list comprehension stuff but then I gave up and @danielhochman helped me with this version which seems to work. (The old version was whitelisting everything it seems). Let me know what you think. |
Member
|
LGTM, my bad.
…On Tue, Jul 11, 2017 at 7:40 PM Matt Klein ***@***.***> wrote:
------------------------------
You can view, comment on, or merge this pull request online at:
#1242
Commit Summary
- fix format: fix white list
File Changes
- *M* tools/check_format.py
<https://github.com/lyft/envoy/pull/1242/files#diff-0> (4)
Patch Links:
- https://github.com/lyft/envoy/pull/1242.patch
- https://github.com/lyft/envoy/pull/1242.diff
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#1242>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AKaLv6EGsa7kpUNqUBcnsRN0nJ_iVh6Mks5sNAfSgaJpZM4OU8qO>
.
|
danielhochman
approved these changes
Jul 11, 2017
rshriram
pushed a commit
to rshriram/envoy
that referenced
this pull request
Oct 30, 2018
Automatic merge from submit-queue. Check quota cache hit **What this PR does / why we need it**: When Check() is enabled, Mixer filter sends attributes check.cache_hit and quota.cache_hit in Report() call. When Check() is disabled, Mixer filter does not send these attributes. **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1181 **Special notes for your reviewer**: **Release note**: ```release-note NONE ```
jpsim
pushed a commit
that referenced
this pull request
Nov 28, 2022
Description: This PR moves all of the library/cc and library/python C++ methods from snake_case to camelCase per Envoy coding guidelines. Risk Level: Low Testing: bazel test //library/python/integration:test_send_headers Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
jpsim
pushed a commit
that referenced
this pull request
Nov 29, 2022
Description: This PR moves all of the library/cc and library/python C++ methods from snake_case to camelCase per Envoy coding guidelines. Risk Level: Low Testing: bazel test //library/python/integration:test_send_headers Docs Changes: N/A Release Notes: N/A Signed-off-by: Cerek Hillen <chillen@lyft.com> Signed-off-by: JP Simard <jp@jpsim.com>
mathetake
pushed a commit
that referenced
this pull request
Mar 3, 2026
**Description** This PR adds OpenAI's legacy `/completions` endpoint support to Envoy AI Gateway, enabling compatibility with models like `babbage-002` and `gpt-3.5-turbo-instruct`. Ideal for cost-optimized or fine-tuned setups (e.g., vLLM/llama.cpp) needing suffix params or token prompts. Refactored unions (`ContentUnion`, `EmbeddingRequestInput`, `PromptUnion`) with custom unmarshaling for **1.6x–10x speedups**, **60%–95% less memory**, and **52%–93% fewer allocations** vs. openai-go. Gains are critical for batch/token-heavy workloads. *Key Changes* - New types: `CompletionRequest`, `CompletionResponse`, `PromptUnion`. - Model constants for legacy testing. - Unified `Usage` across APIs. - New Benchmarks! **Related Issues/PRs** Starts #1231 --------- Signed-off-by: Adrian Cole <adrian@tetrate.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.