Skip to content

fix format: fix white list#1242

Merged
mattklein123 merged 1 commit intomasterfrom
fix_fix_format
Jul 11, 2017
Merged

fix format: fix white list#1242
mattklein123 merged 1 commit intomasterfrom
fix_fix_format

Conversation

@mattklein123
Copy link
Copy Markdown
Member

No description provided.

@mattklein123
Copy link
Copy Markdown
Member Author

@htuch I'm not very good at Python but what you had here before didn't work for me. I tried to understand the list comprehension stuff but then I gave up and @danielhochman helped me with this version which seems to work. (The old version was whitelisting everything it seems). Let me know what you think.

@htuch
Copy link
Copy Markdown
Member

htuch commented Jul 11, 2017 via email

@mattklein123 mattklein123 merged commit 7cbacb8 into master Jul 11, 2017
@mattklein123 mattklein123 deleted the fix_fix_format branch July 11, 2017 23:59
rshriram pushed a commit to rshriram/envoy that referenced this pull request Oct 30, 2018
Automatic merge from submit-queue.

Check quota cache hit

**What this PR does / why we need it**: When Check() is enabled, Mixer filter sends attributes check.cache_hit and quota.cache_hit in Report() call. When Check() is disabled, Mixer filter does not send these attributes.

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes envoyproxy#1181 

**Special notes for your reviewer**:

**Release note**:

```release-note
NONE
```
jpsim pushed a commit that referenced this pull request Nov 28, 2022
Description: This PR moves all of the library/cc and library/python C++ methods from snake_case to camelCase per Envoy coding guidelines.

Risk Level: Low

Testing: bazel test //library/python/integration:test_send_headers

Docs Changes: N/A

Release Notes: N/A

Signed-off-by: Cerek Hillen <chillen@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
jpsim pushed a commit that referenced this pull request Nov 29, 2022
Description: This PR moves all of the library/cc and library/python C++ methods from snake_case to camelCase per Envoy coding guidelines.

Risk Level: Low

Testing: bazel test //library/python/integration:test_send_headers

Docs Changes: N/A

Release Notes: N/A

Signed-off-by: Cerek Hillen <chillen@lyft.com>
Signed-off-by: JP Simard <jp@jpsim.com>
mathetake pushed a commit that referenced this pull request Mar 3, 2026
**Description**

This PR adds OpenAI's legacy `/completions` endpoint support to Envoy AI
Gateway, enabling compatibility with models like `babbage-002` and
`gpt-3.5-turbo-instruct`. Ideal for cost-optimized or fine-tuned setups
(e.g., vLLM/llama.cpp) needing suffix params or token prompts.

Refactored unions (`ContentUnion`, `EmbeddingRequestInput`,
`PromptUnion`) with custom unmarshaling for **1.6x–10x speedups**,
**60%–95% less memory**, and **52%–93% fewer allocations** vs.
openai-go. Gains are critical for batch/token-heavy workloads.

*Key Changes*
- New types: `CompletionRequest`, `CompletionResponse`, `PromptUnion`.
- Model constants for legacy testing.
- Unified `Usage` across APIs.
- New Benchmarks!

**Related Issues/PRs**

Starts #1231 

---------

Signed-off-by: Adrian Cole <adrian@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants