[build] Fix clang-tidy errors in the LinkedObject::moveIntoList* methods#12378
Merged
yanavlasov merged 2 commits intoenvoyproxy:masterfrom Jul 30, 2020
Merged
[build] Fix clang-tidy errors in the LinkedObject::moveIntoList* methods#12378yanavlasov merged 2 commits intoenvoyproxy:masterfrom
yanavlasov merged 2 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
alyssawilk
reviewed
Jul 30, 2020
Contributor
alyssawilk
left a comment
There was a problem hiding this comment.
LGTM overall, though can these be static functions in the existing class rather than having their own namesapce?
alyssawilk
approved these changes
Jul 30, 2020
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
…oyproxy#12378) Fix clang-tidy errors in the LinkedObject::moveIntoList* methods Signed-off-by: Yan Avlasov <yavlasov@google.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
…oyproxy#12378) Fix clang-tidy errors in the LinkedObject::moveIntoList* methods Signed-off-by: Yan Avlasov <yavlasov@google.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
PiotrSikora
pushed a commit
to PiotrSikora/envoy
that referenced
this pull request
Aug 7, 2020
…oyproxy#12378) Fix clang-tidy errors in the LinkedObject::moveIntoList* methods Signed-off-by: Yan Avlasov <yavlasov@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Fix clang-tidy errors in the LinkedObject::moveIntoList* methods
Additional Description:
There is no real problem as the actual move happens inside the method, but it is cleaner.
Risk Level: Low
Testing: Unit Tests
Docs Changes: N/A
Release Notes: N/A
Fixes #11691
Signed-off-by: Yan Avlasov yavlasov@google.com