Skip to content

Revert "Redis fault injection (#10784)"#12371

Merged
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
HenryYYang:revert-redis-fault-injection
Jul 30, 2020
Merged

Revert "Redis fault injection (#10784)"#12371
mattklein123 merged 2 commits intoenvoyproxy:masterfrom
HenryYYang:revert-redis-fault-injection

Conversation

@FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg
Copy link
Copy Markdown
Contributor

This reverts commit 048583b.

Signed-off-by: FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg nflacco@lyft.com

This reverts commit 048583b.

Signed-off-by: FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg <nflacco@lyft.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12371 was opened by FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg.

see: more, trace.

mattklein123
mattklein123 previously approved these changes Jul 29, 2020
Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(Note this commit is causing issues at Lyft and needs to be debugged)

@mattklein123 mattklein123 self-assigned this Jul 29, 2020
Signed-off-by: FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg <nflacco@lyft.com>
@mattklein123 mattklein123 merged commit f521fc7 into envoyproxy:master Jul 30, 2020
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
This reverts commit 048583b.

Signed-off-by: FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg <nflacco@lyft.com>
chaoqin-li1123 pushed a commit to chaoqin-li1123/envoy that referenced this pull request Aug 7, 2020
This reverts commit 048583b.

Signed-off-by: FAYiEKcbD0XFqF2QK2E4viAHg8rMm2VbjYKdjTg <nflacco@lyft.com>
Signed-off-by: chaoqinli <chaoqinli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants