Windows: Enable now-passing unit tests#12343
Merged
mattklein123 merged 1 commit intoenvoyproxy:masterfrom Aug 10, 2020
greenhouse-org:identify-passing-windows-tests
Merged
Windows: Enable now-passing unit tests#12343mattklein123 merged 1 commit intoenvoyproxy:masterfrom greenhouse-org:identify-passing-windows-tests
mattklein123 merged 1 commit intoenvoyproxy:masterfrom
greenhouse-org:identify-passing-windows-tests
Conversation
Member
Author
Member
Author
Contributor
Contributor
Member
Author
|
Logs from latest run: https://dev.azure.com/cncf/4684fb3d-0389-4e0b-8251-221942316e06/_apis/build/builds/46650/logs/81
|
Member
Author
|
Set to reviewable just to get CI to run |
Signed-off-by: William A Rowe Jr <wrowe@vmware.com> Co-authored-by: Sunjay Bhatia <sunjayb@vmware.com>
Member
Author
|
This PR is now ready for review, we will move debugging integration tests into another PR |
Member
Author
|
The remaining non-integration tests that are failing are: |
jmarantz
approved these changes
Aug 10, 2020
Contributor
|
Lizan -- this is pretty trivial but can you give it a @envoyproxy/senior-maintainers stamp of approval? |
Contributor
|
@jmarantz - not only trivial. It's a no-op on Linux, macOS, iOS and Android. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message:
Windows: Enable now-passing unit tests
This pass only enables passing unit tests, integration tests have been flaky and are being worked on in a separate effort.
Enabled tests:
Additional Description: N/A
Risk Level: Low
Testing: Validated tests passing locally and via RBE
Docs Changes: N/A
Release Notes: N/A