Guard check that event_base_new initializes correctly#12218
Merged
mattklein123 merged 5 commits intoenvoyproxy:masterfrom Jul 30, 2020
Merged
Guard check that event_base_new initializes correctly#12218mattklein123 merged 5 commits intoenvoyproxy:masterfrom
mattklein123 merged 5 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: davinci26 <sotirisnan@gmail.com>
Member
Author
|
cc the usual windows crew @wrowe @sunjayBhatia @nigriMSFT |
Signed-off-by: davinci26 <sotirisnan@gmail.com>
jmarantz
reviewed
Jul 22, 2020
Contributor
jmarantz
left a comment
There was a problem hiding this comment.
looks fine; just a style nit
Signed-off-by: davinci26 <sotirisnan@gmail.com>
sunjayBhatia
suggested changes
Jul 30, 2020
|
|
||
| LibeventScheduler::LibeventScheduler() : libevent_(event_base_new()) { | ||
| LibeventScheduler::LibeventScheduler() { | ||
| event_base* eventBase = event_base_new(); |
Member
There was a problem hiding this comment.
I believe @jmarantz was requesting the variable eventBase be snake cased to event_base (#12218 (comment))
Member
Author
There was a problem hiding this comment.
thanks totally missed this one
Signed-off-by: davinci26 <sotirisnan@gmail.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Signed-off-by: davinci26 <sotirisnan@gmail.com>
chaoqin-li1123
pushed a commit
to chaoqin-li1123/envoy
that referenced
this pull request
Aug 7, 2020
Signed-off-by: davinci26 <sotirisnan@gmail.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com
Add a release assert to the libevent
event_base_new()to make sure that the initialization is correct and make envoy fail fast if it fails.Additional Description:
This scenario crashes with an Access Violation at later stages. With this change we just make sure that we crash closer to where we actually failed.
Risk Level: low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A