Add histogram for maximum concurrent requests per connection#12241
Closed
ggreenway wants to merge 1 commit intoenvoyproxy:masterfrom
Closed
Add histogram for maximum concurrent requests per connection#12241ggreenway wants to merge 1 commit intoenvoyproxy:masterfrom
ggreenway wants to merge 1 commit intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Greg Greenway <ggreenway@apple.com>
Member
Author
|
Questions:
|
Member
Author
mattklein123
requested changes
Jul 23, 2020
Member
mattklein123
left a comment
There was a problem hiding this comment.
Makes sense to me. LMK when you have cleaned up with docs, etc.
/wait
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
jmarantz
added a commit
that referenced
this pull request
Aug 11, 2020
…e so that two with the same name map to the same histogram object. (#12275) Commit Message: Creates a storage model for thread-local histograms enabling continuity of data across scope reloads. Previously, whenever a Scope was re-created, the counters, gauges, and text-readouts of the same names would retain their previous values. However, fresh histograms were created on every scope reload, and stats dumps would include duplicate histograms with the same name. This change adds an analogous name-based set of histograms, held in ThreadLocalStore, so that we have a single histogram representing all its generations of data. This is somewhat more complex than for the other stats, since there were thread-local buffers, which previously were owned by TlsScope and needed to be made independent. So this introduces a new tls histogram map in the tls-cache to maintain this. This should help unblock #12241. Additional Description: Risk Level: high (not clear whether this is enough testing of histogram usage) Testing: //test/... Docs Changes: n/a Release Notes: n/a Fixes: #3098 Signed-off-by: Joshua Marantz <jmarantz@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Greg Greenway ggreenway@apple.com
Commit Message: This gives visibility into concurrent connections, and can help in setting an appropriate value for
http2_protocol_options.max_concurrent_streams.Additional Description:
Risk Level: low
Testing: TODO
Docs Changes: TODO
Release Notes: TODO
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]