Skip to content

[fuzz] fix filter crashes from OSS fuzz#12152

Merged
asraa merged 4 commits intoenvoyproxy:masterfrom
samflattery:filter_crash
Jul 20, 2020
Merged

[fuzz] fix filter crashes from OSS fuzz#12152
asraa merged 4 commits intoenvoyproxy:masterfrom
samflattery:filter_crash

Conversation

@samflattery
Copy link
Copy Markdown
Contributor

Commit Message: Fix filter crashes from OSS fuzz due to unimplemented proto fields
Additional Description:

  • raise an exception that will be caught and abort the test run when an unimplemented oneof field is hit by the fuzzer

Risk Level: Low
Testing: regression test added
Docs Changes: N/A
Release Notes: N/A
Fixes: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=24050

Sam Flattery added 2 commits July 17, 2020 17:12
Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Sam Flattery <samflattery@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #12152 was opened by samflattery.

see: more, trace.

@samflattery
Copy link
Copy Markdown
Contributor Author

/cc @asraa

Sam Flattery added 2 commits July 17, 2020 17:27
Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Sam Flattery <samflattery@google.com>
Copy link
Copy Markdown
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.
Thanks for the TODO and the comment referencing back!

@asraa asraa merged commit e6c57fa into envoyproxy:master Jul 20, 2020
@samflattery samflattery deleted the filter_crash branch July 20, 2020 12:40
KBaichoo pushed a commit to KBaichoo/envoy that referenced this pull request Jul 30, 2020
* fix filter fuzzer crash from OSS fuzz by checking for non-implemented proto fields
This will raise an exception that will be caught and abort the test run when an unimplemented oneof field is hit by the fuzzer

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
scheler pushed a commit to scheler/envoy that referenced this pull request Aug 4, 2020
* fix filter fuzzer crash from OSS fuzz by checking for non-implemented proto fields
This will raise an exception that will be caught and abort the test run when an unimplemented oneof field is hit by the fuzzer

Signed-off-by: Sam Flattery <samflattery@google.com>
Signed-off-by: scheler <santosh.cheler@appdynamics.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants