pgv: update to add wasm32 enabled re2#12129
pgv: update to add wasm32 enabled re2#12129Shikugawa wants to merge 6 commits intoenvoyproxy:masterfrom
Conversation
Signed-off-by: Shikugawa <rei@tetrate.io>
|
/assign @htuch |
htuch
left a comment
There was a problem hiding this comment.
Thanks. Can you also update check_format to ensure that the consistency of these files is validated so we don't regress in the future in this way?
@htuch Is it enough to take diff between |
|
@Shikugawa yep! |
#12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl Risk Level: Low Signed-off-by: Shikugawa <rei@tetrate.io>
|
@Shikugawa could you check CI and expand the commit message please? Thanks! |
|
@dio This is blocked by this... Do you have any idea about this? bufbuild/protoc-gen-validate#360 |
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
…-format-pgv Signed-off-by: Shikugawa <rei@tetrate.io>
|
@htuch PTAL |
envoyproxy#12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl Risk Level: Low Signed-off-by: Shikugawa <rei@tetrate.io> Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
envoyproxy#12129 (review), to ensure the consistency between api/bazel/*.bzl and generated_api_shadow/bazel/*.bzl Risk Level: Low Signed-off-by: Shikugawa <rei@tetrate.io> Signed-off-by: scheler <santosh.cheler@appdynamics.com>
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
| # go version for rules_go | ||
| GO_VERSION = "1.14.4" | ||
|
|
||
| def envoy_api_dependency_import(): |
There was a problem hiding this comment.
How come this change is made to the Envoy bazel/ rather than api/bazel/? If this is something needed for any use of the APIs, it probably belongs in the latter.
|
This pull request has been automatically marked as stale because it has not had activity in the last 7 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 14 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
Commit Message: reflect. #12100 (comment). To add wasm32 enabled re2.
Additional Description: As a response to the following comment: #12100 (comment)
Risk Level: Low
Testing: Existing tests
Docs Changes: N/A
Release Notes: N/A
Signed-off-by: Shikugawa rei@tetrate.io