Wasm upstreaming: required bazel/* support.#12116
Conversation
80a2fb1 to
69ccf0f
Compare
Signed-off-by: John Plevyak <jplevyak@gmail.com>
69ccf0f to
5a2a381
Compare
|
ERROR: Codecs are not synced: ./source/common/http/http2/codec_impl.cc does not match ./source/common/http/http2/codec_impl_legacy.cc. Update codec implementations to sync and/or update the diff manually to: What is this? |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
//test/extensions/filters/network/rbac:integration_test FAILED Suggestions? |
|
Updated wee8 => v8. PTAL |
|
Could someone with permission kick circleci ? The go_control_plain_mirror failure seems like a flake. |
|
/retest |
|
🔨 rebuilding |
…tream-wasm-bazel Signed-off-by: John Plevyak <jplevyak@gmail.com>
e4995f5 to
1a66ea1
Compare
| **kwargs | ||
| ) | ||
|
|
||
| wasm_binary( |
There was a problem hiding this comment.
do we need proxy_wasm_cpp_sdk, wasm_binary in the envoy repo?
mainly asking as this pulls in emscripten as a dependency, which adds bloat to building envoy.
There was a problem hiding this comment.
Not only is it intentional it is the title of the PR. Do you have some suggestion as to how we can support Wasm without adding the sdk and wasm binary to the the envoy repo?
There was a problem hiding this comment.
AFAIK envoy only needs proxy_wasm_cpp_host, and does not need to build wasm binaries.
proxy_wasm_cpp_sdk is for building filters, which is not done by envoy. so not sure why is it needed.
if i want to build a filter with the cpp-sdk, I can add the proxy_wasm_cpp_host to my filter project directly.
is it the intention to fold https://github.com/proxy-wasm/proxy-wasm-cpp-sdk back into this repo?
There was a problem hiding this comment.
This is used for building tests in Envoy (vs checking-in compiled .wasm files).
There was a problem hiding this comment.
Yeah this is needed for test (without checking-in binaries).
|
@jplevyak fix the typo? there's bunch of NDBUG vs NDEBUG. otherwise LGTM |
Signed-off-by: John Plevyak <jplevyak@gmail.com>
|
Could someone kick this? Or perhaps I should sync again? |
|
re-kicked |
…tream-wasm-bazel
Add authority field in envoy grpc message to override the default host name as cluster name. Risk Level: Low Testing: Docs Changes: Release Notes: Fix #12116 Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Merge in changes from envoyproxy/envoy-wasm in the bazel/ directory as part of upstreaming Wasm. Risk Level: Low Testing: Unit tests pass. Docs Changes: N/A Release Notes: N/A Signed-off-by: John Plevyak <jplevyak@gmail.com>
Add authority field in envoy grpc message to override the default host name as cluster name. Risk Level: Low Testing: Docs Changes: Release Notes: Fix envoyproxy#12116 Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Merge in changes from envoyproxy/envoy-wasm in the bazel/ directory as part of upstreaming Wasm. Risk Level: Low Testing: Unit tests pass. Docs Changes: N/A Release Notes: N/A Signed-off-by: John Plevyak <jplevyak@gmail.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
Add authority field in envoy grpc message to override the default host name as cluster name. Risk Level: Low Testing: Docs Changes: Release Notes: Fix envoyproxy#12116 Signed-off-by: Yuchen Dai <silentdai@gmail.com> Signed-off-by: chaoqinli <chaoqinli@google.com>
For an explanation of how to fill out the fields, please see the relevant section
in PULL_REQUESTS.md
Description: Merge in changes from envoyproxy/envoy-wasm in the bazel/ directory as part of upstreaming Wasm.
Risk Level: Low
Testing: Unit tests pass.
Docs Changes: N/A
Release Notes: N/A
[Optional Fixes #Issue]
[Optional Deprecated:]